Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Side by Side Diff: src/apinatives.js

Issue 6445: This change removes the %AddProperty native JavaScript function from V8.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/array.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 60
61 function InstantiateFunction(data, name) { 61 function InstantiateFunction(data, name) {
62 var serialNumber = %GetTemplateField(data, kApiSerialNumberOffset); 62 var serialNumber = %GetTemplateField(data, kApiSerialNumberOffset);
63 if (!(serialNumber in kApiFunctionCache)) { 63 if (!(serialNumber in kApiFunctionCache)) {
64 kApiFunctionCache[serialNumber] = null; 64 kApiFunctionCache[serialNumber] = null;
65 var fun = %CreateApiFunction(data); 65 var fun = %CreateApiFunction(data);
66 if (name) %FunctionSetName(fun, name); 66 if (name) %FunctionSetName(fun, name);
67 kApiFunctionCache[serialNumber] = fun; 67 kApiFunctionCache[serialNumber] = fun;
68 var prototype = %GetTemplateField(data, kApiPrototypeTemplateOffset); 68 var prototype = %GetTemplateField(data, kApiPrototypeTemplateOffset);
69 fun.prototype = prototype ? Instantiate(prototype) : {}; 69 fun.prototype = prototype ? Instantiate(prototype) : {};
70 %AddProperty(fun.prototype, "constructor", fun, DONT_ENUM); 70 %SetProperty(fun.prototype, "constructor", fun, DONT_ENUM);
71 var parent = %GetTemplateField(data, kApiParentTemplateOffset); 71 var parent = %GetTemplateField(data, kApiParentTemplateOffset);
72 if (parent) { 72 if (parent) {
73 var parent_fun = Instantiate(parent); 73 var parent_fun = Instantiate(parent);
74 fun.prototype.__proto__ = parent_fun.prototype; 74 fun.prototype.__proto__ = parent_fun.prototype;
75 } 75 }
76 ConfigureTemplateInstance(fun, data); 76 ConfigureTemplateInstance(fun, data);
77 } 77 }
78 return kApiFunctionCache[serialNumber]; 78 return kApiFunctionCache[serialNumber];
79 } 79 }
80 80
81 81
82 function ConfigureTemplateInstance(obj, data) { 82 function ConfigureTemplateInstance(obj, data) {
83 var properties = %GetTemplateField(data, kApiPropertyListOffset); 83 var properties = %GetTemplateField(data, kApiPropertyListOffset);
84 if (properties) { 84 if (properties) {
85 for (var i = 0; i < properties[0]; i += 3) { 85 for (var i = 0; i < properties[0]; i += 3) {
86 var name = properties[i + 1]; 86 var name = properties[i + 1];
87 var prop_data = properties[i + 2]; 87 var prop_data = properties[i + 2];
88 var attributes = properties[i + 3]; 88 var attributes = properties[i + 3];
89 var value = Instantiate(prop_data, name); 89 var value = Instantiate(prop_data, name);
90 %SetProperty(obj, name, value, attributes); 90 %SetProperty(obj, name, value, attributes);
91 } 91 }
92 } 92 }
93 } 93 }
OLDNEW
« no previous file with comments | « no previous file | src/array.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698