Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 6442: Let's try this again. The regressions were caused by an incorrect use... (Closed)

Created:
12 years, 2 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
plesner, Feng Qian
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Let's try this again. The regressions were caused by an incorrect use of the current context instead of last entered context. Create node wrappers in the context to which the nodes belong instead of the context of the code accessing them. This fixes the issue where the prototype library does not work if the JavaScript console is open. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2826

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -4 lines) Patch
A webkit/data/layout_tests/chrome/fast/dom/resources/wrapper-context-inner.html View 1 chunk +28 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/chrome/fast/dom/wrapper-context.html View 1 chunk +33 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/chrome/fast/dom/wrapper-context-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/port/bindings/v8/v8_custom.cpp View 1 chunk +6 lines, -4 lines 0 comments Download
M webkit/port/bindings/v8/v8_proxy.cpp View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Mads Ager (chromium)
12 years, 2 months ago (2008-10-03 10:33:08 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698