Issue 6441: - Added fast case for extending the JSObject properties storage....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6441: - Added fast case for extending the JSObject properties storage.... (Closed)

Created:
12 years, 2 months ago by bak

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

- Added fast case for extending the JSObject properties storage. - Changed date to compute local_time_offset at load time. Committed: http://code.google.com/p/v8/source/detail?r=420

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+121 lines, -43 lines)			Patch
M	src/builtins.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/builtins.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/date-delay.js	View	4 chunks	+4 lines, -15 lines	0 comments	Download
M	src/handles.cc	View	1 chunk	+12 lines, -7 lines	0 comments	Download
M	src/ic.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/ic.cc	View	4 chunks	+38 lines, -7 lines	1 comment	Download
M	src/ic-arm.cc	View	2 chunks	+16 lines, -3 lines	0 comments	Download
M	src/ic-ia32.cc	View	2 chunks	+19 lines, -3 lines	0 comments	Download
M	src/stub-cache-arm.cc	View	1 chunk	+12 lines, -4 lines	0 comments	Download
M	src/stub-cache-ia32.cc	View	1 chunk	+12 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

12 years, 2 months ago (2008-10-03 09:12:44 UTC) #2

LGTM!

http://codereview.chromium.org/6441/diff/1/5
File src/ic.cc (right):

http://codereview.chromium.org/6441/diff/1/5#newcode1134
Line 1134: int  new_size = old_storage->length() + new_unused + 1;
Please remove extra space between type and name.

Expand Messages | Collapse Messages