Issue 6437001: Pull in a named constant from WebKit

Issue 6437001: Pull in a named constant from WebKit (Closed)

Created:
9 years, 10 months ago by Ilya Sherman

Modified:
9 years, 7 months ago

Reviewers:
dhollowa

CC:
chromium-reviews, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org, James Hawkins, Ilya Sherman, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Pull in a named constant from WebKit BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74867

Patch Set 2 : Updated to work around initialization order issues. Needs webkit change. #

Patch Set 3 : Const-ref instead #

Patch Set 4 : Fix the AutoFillMerge test as well #

Patch Set 6 : Unwrapped in all its glory #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+210 lines, -210 lines)			Patch
M	chrome/browser/autofill/autofill_merge_unittest.cc	View	1 2 3 4	2 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/renderer/autofill/form_manager_browsertest.cc	View	1 2 3 4 5	38 chunks	+204 lines, -194 lines	0 comments	Download
M	chrome/renderer/render_view_browsertest.cc	View	1 3	3 chunks	+4 lines, -11 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

dhollowa

Sorry, I think we should make it |DefaultMaxLength()| (no "k") to conform to style guide. ...

9 years, 10 months ago (2011-02-11 17:11:22 UTC) #4

dhollowa

http://codereview.chromium.org/6437001/diff/9001/chrome/renderer/autofill/form_manager_browsertest.cc File chrome/renderer/autofill/form_manager_browsertest.cc (right): http://codereview.chromium.org/6437001/diff/9001/chrome/renderer/autofill/form_manager_browsertest.cc#newcode105 chrome/renderer/autofill/form_manager_browsertest.cc:105: static int kDefaultMaxLength() { Actually, let's just get rid ...

9 years, 10 months ago (2011-02-11 17:14:32 UTC) #5

Ilya Sherman

9 years, 10 months ago (2011-02-11 21:34:00 UTC) #6

LGTM.  Thanks.

Expand Messages | Collapse Messages