Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 6433001: Use crossystem in factory install (Closed)

Created:
9 years, 10 months ago by Nick Sanders
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Use crossystem BUG=chrome-os-partner:2251 TEST=works Change-Id: I44099026b3ca276037fc0d09f2ce35413f97da08 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=697bec9

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -16 lines) Patch
M factory_install.sh View 1 chunk +7 lines, -16 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Nick Sanders
Factory install script crossystemification
9 years, 10 months ago (2011-02-08 06:15:22 UTC) #1
Randall Spangler
LGTM
9 years, 10 months ago (2011-02-08 17:52:27 UTC) #2
Hung-Te
9 years, 10 months ago (2011-02-18 03:44:07 UTC) #3
http://codereview.chromium.org/6433001/diff/2001/factory_install.sh
File factory_install.sh (right):

http://codereview.chromium.org/6433001/diff/2001/factory_install.sh#newcode81
factory_install.sh:81: if [ "$(crossystem wpsw_cur)" = "0" ; then
Missing a "]"? (although it's not really necessary)

Powered by Google App Engine
This is Rietveld 408576698