Issue 643001: Refactor assignments in the ia32 code generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 643001: Refactor assignments in the ia32 code generator. (Closed)

Created:
10 years, 10 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
William Hesse, Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Refactor assignments in the ia32 code generator. Change compilation of assignment expressions in the ia32 code generator to no longer use the Reference helper class. This gives us more explicit control over which subexpressions are evaluated and when. Committed: http://code.google.com/p/v8/source/detail?r=3899

Patch Set 1 #

Patch Set 2 : Replace inadvertent CHECK with ASSERT. #

Patch Set 3 : Merged with bleeding_edge@HEAD. #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+433 lines, -321 lines)			Patch
	M	src/ia32/codegen-ia32.h	View	1	1 chunk	+15 lines, -4 lines	0 comments	Download
	M	src/ia32/codegen-ia32.cc	View	1 2	13 chunks	+418 lines, -317 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages