Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 6430: [Chromium-reviews] Fix issue 3039/3040 (Add to dictionary crasher) (Closed)

Created:
12 years, 2 months ago by sidchat (Google)
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix issue 3039/3040 (Add to dictionary crasher). Earlier, the hentry was being generated manually, and incorrectly, when add to dictionary was trigerred, leading to failures occasionally in hunspell. This patch generates the hentry using existing hunspell method for generating hentry. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2850

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -19 lines) Patch
M chrome/third_party/hunspell/src/hunspell/hashmgr.hxx View 1 chunk +1 line, -1 line 0 comments Download
M chrome/third_party/hunspell/src/hunspell/hashmgr.cxx View 3 chunks +10 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sidchat (Google)
This is urgent as it hopefully resolves a P1 crasher which can sometimes make text ...
12 years, 2 months ago (2008-10-02 23:17:18 UTC) #1
brettw
Can you add a description of the problem in the change description? It's not obvious ...
12 years, 2 months ago (2008-10-03 15:19:52 UTC) #2
sidchat (Google)
I updated the description - essentially, hentry is now being generated properly, using the dedicated ...
12 years, 2 months ago (2008-10-03 18:11:41 UTC) #3
brettw
12 years, 2 months ago (2008-10-03 19:29:48 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698