Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 6413004: Add a presubmit test that asserts TODOs have owners.... (Closed)

Created:
9 years, 10 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
Evan Martin, M-A Ruel
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Add a presubmit test that asserts TODOs have owners. For example, TODO(foo) is ok, but TODO: do something is not. BUG=none TEST=included Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74032

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M presubmit_canned_checks.py View 1 chunk +12 lines, -0 lines 0 comments Download
M tests/presubmit_unittest.py View 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Stade
9 years, 10 months ago (2011-02-05 02:04:28 UTC) #1
M-A Ruel
9 years, 10 months ago (2011-02-05 02:11:20 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698