Issue 6410125: Extend Mac popup to handle more directionality....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6410125: Extend Mac popup to handle more directionality.... (Closed)

Created:
9 years, 10 months ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Extend Mac popup to handle more directionality. BUG=71326 TEST=verify popup is correct with test page noted in bug writeup. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74622

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+102 lines, -86 lines)			Patch
M	chrome/common/render_messages.cc	View	3 chunks	+12 lines, -4 lines	0 comments	Download
M	webkit/glue/webmenuitem.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/webmenuitem.cc	View	3 chunks	+6 lines, -0 lines	0 comments	Download
M	webkit/glue/webmenurunner_mac.h	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	webkit/glue/webmenurunner_mac.mm	View	5 chunks	+78 lines, -81 lines	0 comments	Download

Total messages: 2 (0 generated)

Avi (use Gerrit)

Notes: - This will require the landing of the WebKit side of the patch first. ...

9 years, 10 months ago (2011-02-07 21:19:34 UTC) #1

Looks like it’ll work. LGTM.