Issue 6410121: NTP: Fix restore all

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6410121: NTP: Fix restore all (Closed)

Created:
9 years, 10 months ago by arv (Not doing code reviews)

Modified:
9 years, 3 months ago

Reviewers:
arv1, Miranda Callahan

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

NTP: Fix restore all There was an error in hideNotification which prevented us from refreshing the most visited section. BUG=71724 TEST=Go to NTP Show most visited Black list a most visited item Now click the restore all link The items should be restored Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74015

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	chrome/browser/resources/new_new_tab.js	View		1 chunk	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Miranda Callahan

d'oh -- I need to write javascript more than once a month. thanks, LGTM.

9 years, 10 months ago (2011-02-07 18:43:44 UTC) #2

arv1

9 years, 10 months ago (2011-02-07 19:06:59 UTC) #3

I didn't see this when I reviewed it so it just as much my fault.

On 10:43 am, mirandac <mirandac@chromium.org> wrote:
> d'oh -- I need to write javascript more than once a month. thanks, LGTM.

Expand Messages | Collapse Messages