Issue 6410120: Refactor lithium instructions for constants....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6410120: Refactor lithium instructions for constants.... (Closed)

Created:
9 years, 10 months ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Chromium), Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Refactor lithium instructions for constants. 1. Remove unnecessary superlcass LConstant. 2. Use hydrogen accessor instead of duplicating the value. Committed: http://code.google.com/p/v8/source/detail?r=6672

Patch Set 1 #

Total comments: 1

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -198 lines)			Patch
M	src/arm/lithium-arm.h	View	2 chunks	+9 lines, -24 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View	2 chunks	+9 lines, -24 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	src/x64/lithium-x64.h	View	2 chunks	+10 lines, -135 lines	1 comment	Download
M	src/x64/lithium-x64.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

9 years, 10 months ago (2011-02-08 10:34:44 UTC) #3

LGTM.

http://codereview.chromium.org/6410120/diff/1/src/x64/lithium-x64.h
File src/x64/lithium-x64.h (left):

http://codereview.chromium.org/6410120/diff/1/src/x64/lithium-x64.h#oldcode43
src/x64/lithium-x64.h:43: // Type hierarchy:
Yay!

Expand Messages | Collapse Messages