Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 6410064: Fix FileIO and FileRef PPAPI tests to match changes in (Closed)

Created:
9 years, 10 months ago by adamk
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix FileIO and FileRef PPAPI tests to match changes in http://src.chromium.org/viewvc/chrome?view=rev&revision=71544, and try re-enabling them in the UI tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73677

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed long line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -29 lines) Patch
M chrome/test/ui/ppapi_uitest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ppapi/tests/test_file_io.cc View 1 12 chunks +13 lines, -12 lines 0 comments Download
M ppapi/tests/test_file_ref.cc View 9 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
adamk
9 years, 10 months ago (2011-02-03 20:52:24 UTC) #1
darin (slow to review)
nice, glad to see this was so trivial to fix. http://codereview.chromium.org/6410064/diff/1/ppapi/tests/test_file_io.cc File ppapi/tests/test_file_io.cc (right): http://codereview.chromium.org/6410064/diff/1/ppapi/tests/test_file_io.cc#newcode330 ...
9 years, 10 months ago (2011-02-03 21:05:37 UTC) #2
adamk
On Thu, Feb 3, 2011 at 1:05 PM, <darin@chromium.org> wrote: > nice, glad to see ...
9 years, 10 months ago (2011-02-03 21:31:50 UTC) #3
darin (slow to review)
LGTM
9 years, 10 months ago (2011-02-03 21:36:49 UTC) #4
commit-bot: I haz the power
9 years, 10 months ago (2011-02-03 22:20:17 UTC) #5
Change committed as 73677

Powered by Google App Engine
This is Rietveld 408576698