Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Issue 6410030: Heap profiler: fix removed DOM wrappers reporting. (Closed)

Created:
9 years, 10 months ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Heap profiler: fix removed DOM wrappers reporting. Aggregated snapshots: don't report unreachable objects. Full snapshots: restore forcing GC prior to taking a snapshot. I played with the repro page provided for the bug and found that GC must be performed prior to taking a snapshot even if we only report reachable objects. GC allows weak handles to finalize. Now heap profiler produces aligned results for the repro page in both modes. BUG=crbug/70434 TEST=none Committed: http://code.google.com/p/v8/source/detail?r=6598

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/heap-profiler.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
mnaganov (inactive)
9 years, 10 months ago (2011-02-02 16:38:47 UTC) #1
Søren Thygesen Gjesse
9 years, 10 months ago (2011-02-03 08:43:26 UTC) #2
LGTM

For DOM wrappers sometimes more GCs can free more, but we probably do not want
to do more than one GC before taking the snapshot.

Powered by Google App Engine
This is Rietveld 408576698