Issue 6410025: Require typed input representation for HTypeof hydrogen instruction....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6410025: Require typed input representation for HTypeof hydrogen instruction.... (Closed)

Created:
9 years, 10 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Require typed input representation for HTypeof hydrogen instruction. BUG=http://code.google.com/p/chromium/issues/detail?id=71647 TEST=test/mjsunit/regress/regress-71647.js Committed: http://code.google.com/p/v8/source/detail?r=6566

Patch Set 1 #

Total comments: 1

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -0 lines)			Patch
	M	src/hydrogen-instructions.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	A	test/mjsunit/regress/regress-71647.js	View		1 chunk	+34 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 10 months ago (2011-02-02 09:43:41 UTC) #2

LGTM!

http://codereview.chromium.org/6410025/diff/1/test/mjsunit/regress/regress-71...
File test/mjsunit/regress/regress-71647.js (right):

http://codereview.chromium.org/6410025/diff/1/test/mjsunit/regress/regress-71...
test/mjsunit/regress/regress-71647.js:1: // Copyright 2010 the V8 project
authors. All rights reserved.
2010 -> 2011

Expand Messages | Collapse Messages