Menu item titles include Windows-style accelerator marker....

Menu item titles include Windows-style accelerator marker.
Macintosh port remove it in runtime, But current implemented logic
is not sufficient for non-English locales.

BUG=chromium:70765
TEST=add new tests and pass it(app_unittests)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73853

[Takashi Toyoshima (Google), 2011-02-03 10:44:37]

TVL, could you review this change?

This is a problem of stripping logic for windows style accelerator marker.

For example, English locale use the title like '&Print' for Print with underline
on the P. On the other hand, Japanese locale use the title like '印刷(&P)'. '印刷'
mean 'Print' in Japanese and it doesn't include the character 'P'. It's usual
case for Japanese. Traditionally, we add '(&P)' after Japanese title and it is a
Microsoft's standard way.

You know, OS X show the accelerator mark in another way and we don't need to add
accelerator marker to menu titles. In this manner, system show the key
combination automatically, so additional indicator like '(P)' is not needed.
This is also Apple's standard way.

I added two tests, and app_unittests passed in my local test.

[TVL, 2011-02-03 13:39:42]

LGTM

(nice, didn't know about this form)

http://codereview.chromium.org/6409039/diff/3001/ui/base/l10n/l10n_util_mac_u...
File ui/base/l10n/l10n_util_mac_unittest.mm (right):

http://codereview.chromium.org/6409039/diff/3001/ui/base/l10n/l10n_util_mac_u...
ui/base/l10n/l10n_util_mac_unittest.mm:36: { @"foo(&b)...", @"foo\u2026" },
include a test case where the accelerator is at the front of the string
"(&b)foo" just to be complete.

[Takashi Toyoshima (Google), 2011-02-04 20:28:06]

Thanks, TVL.

I added new test for the front case.
app_unittests passed all tests.

By the way, I doesn't have a permission to post it to trybot and commit it to
repository. Could you post and commit this change?

http://codereview.chromium.org/6409039/diff/3001/ui/base/l10n/l10n_util_mac_u...
File ui/base/l10n/l10n_util_mac_unittest.mm (right):

http://codereview.chromium.org/6409039/diff/3001/ui/base/l10n/l10n_util_mac_u...
ui/base/l10n/l10n_util_mac_unittest.mm:36: { @"foo(&b)...", @"foo\u2026" },
On 2011/02/03 13:39:42, TVL wrote:
> include a test case where the accelerator is at the front of the string
> "(&b)foo" just to be complete.

Done.

[Robert Sesek, 2011-02-04 22:12:19]

Tom asked me to take over landing this for you. It's now been submitted.

http://src.chromium.org/viewvc/chrome?view=rev&revision=73853

[Takashi Toyoshima (Google), 2011-02-04 22:20:53]

rsesek,
thank you!