Add willis, a tool to show the status of your entire source tree.

Add willis, a tool to show the status of your entire source tree.

Willis was inspired by Bill's wtf script.

Change-Id: Ie58c51bfafe1041bf7e9d6509b2acb050ba55ac7

BUG=None
TEST=run willis, see that there are changes in my tree, be happy

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=60f4fd7

[Kenneth Waters, 2011-02-01 00:56:04]

http://codereview.chromium.org/6409029/diff/1/host/willis
File host/willis (right):

http://codereview.chromium.org/6409029/diff/1/host/willis#newcode14
host/willis:14: """Run a command in a given directory, return stdout"""
Period after stdout.  And a blank line after the docstring.

http://codereview.chromium.org/6409029/diff/1/host/willis#newcode24
host/willis:24: """Search upwards from the a directory to find a file."""
Blank line after the docstring.

http://codereview.chromium.org/6409029/diff/1/host/willis#newcode40
host/willis:40: sys.stdout.write('%s[44m%s[37m%s%s[0m\n' %
'\033[44m\033[37m%s\033[0m\n'

http://codereview.chromium.org/6409029/diff/1/host/willis#newcode40
host/willis:40: sys.stdout.write('%s[44m%s[37m%s%s[0m\n' %
Why not print?

http://codereview.chromium.org/6409029/diff/1/host/willis#newcode59
host/willis:59: (len(lines) == 1 and not re.search("\(no branch\)", lines[0])))
:
"\(no branch\)" is almost certainly wrong.  Did you mean r"\(no branch\)"?

http://codereview.chromium.org/6409029/diff/1/host/willis#newcode67
host/willis:67: if len(status.splitlines()) > 0:
if status.splitlines():

http://codereview.chromium.org/6409029/diff/1/host/willis#newcode80
host/willis:80: """Returns the repo root."""
Add blank line after docstring.

http://codereview.chromium.org/6409029/diff/1/host/willis#newcode84
host/willis:84: if not repo_path:
if repo_path is None:

not "" -> True

http://codereview.chromium.org/6409029/diff/1/host/willis#newcode100
host/willis:100: fulldirs = map(lambda(p): os.path.normpath(os.path.join(root,
p)), repos)
fulldirs = [os.path.normpath(os.path.join(root, p)) for p in repos]

http://codereview.chromium.org/6409029/diff/1/host/willis#newcode101
host/willis:101: reldirs = map(lambda(p): re.sub('^' + base, '.', p), repos)
reldirs = [re.sub('^' + re.escape(base), '.', p) for p in repos]

map() is frowned on.  re.escape is necessary in case base has magic characters.

[robotboy, 2011-02-01 20:44:55]

Comments addressed, PTAL.

Thanks,
    Anton

http://codereview.chromium.org/6409029/diff/1/host/willis
File host/willis (right):

http://codereview.chromium.org/6409029/diff/1/host/willis#newcode14
host/willis:14: """Run a command in a given directory, return stdout"""
On 2011/02/01 00:56:04, Kenneth Waters wrote:
> Period after stdout.  And a blank line after the docstring.

Done.

http://codereview.chromium.org/6409029/diff/1/host/willis#newcode24
host/willis:24: """Search upwards from the a directory to find a file."""
On 2011/02/01 00:56:04, Kenneth Waters wrote:
> Blank line after the docstring.

Done.

http://codereview.chromium.org/6409029/diff/1/host/willis#newcode40
host/willis:40: sys.stdout.write('%s[44m%s[37m%s%s[0m\n' %
On 2011/02/01 00:56:04, Kenneth Waters wrote:
> '\033[44m\033[37m%s\033[0m\n'

Done.

http://codereview.chromium.org/6409029/diff/1/host/willis#newcode40
host/willis:40: sys.stdout.write('%s[44m%s[37m%s%s[0m\n' %
Cut and paste-itis.  Fixed, thanks.

http://codereview.chromium.org/6409029/diff/1/host/willis#newcode59
host/willis:59: (len(lines) == 1 and not re.search("\(no branch\)", lines[0])))
:
Yes, thanks, done.

http://codereview.chromium.org/6409029/diff/1/host/willis#newcode67
host/willis:67: if len(status.splitlines()) > 0:
On 2011/02/01 00:56:04, Kenneth Waters wrote:
> if status.splitlines():

Done.

http://codereview.chromium.org/6409029/diff/1/host/willis#newcode80
host/willis:80: """Returns the repo root."""
On 2011/02/01 00:56:04, Kenneth Waters wrote:
> Add blank line after docstring.

Done.

http://codereview.chromium.org/6409029/diff/1/host/willis#newcode84
host/willis:84: if not repo_path:
On 2011/02/01 00:56:04, Kenneth Waters wrote:
> if repo_path is None:
> 
> not "" -> True

Done.

http://codereview.chromium.org/6409029/diff/1/host/willis#newcode100
host/willis:100: fulldirs = map(lambda(p): os.path.normpath(os.path.join(root,
p)), repos)
On 2011/02/01 00:56:04, Kenneth Waters wrote:
> fulldirs = [os.path.normpath(os.path.join(root, p)) for p in repos]

Done.

http://codereview.chromium.org/6409029/diff/1/host/willis#newcode101
host/willis:101: reldirs = map(lambda(p): re.sub('^' + base, '.', p), repos)
On 2011/02/01 00:56:04, Kenneth Waters wrote:
> reldirs = [re.sub('^' + re.escape(base), '.', p) for p in repos]
> 
> map() is frowned on.  re.escape is necessary in case base has magic
characters.

Done.

[Kenneth Waters, 2011-02-01 20:55:01]

lgtm.

Just a couple of lingering nits.

http://codereview.chromium.org/6409029/diff/3001/host/willis
File host/willis (right):

http://codereview.chromium.org/6409029/diff/3001/host/willis#newcode41
host/willis:41: print('\033[44m\033[37m%s\033[0m' % (relative_name))
print '\033[44m\033[37m%s\033[0m' % relative_name

http://codereview.chromium.org/6409029/diff/3001/host/willis#newcode43
host/willis:43: print('%s' % relative_name)
print relative_name

http://codereview.chromium.org/6409029/diff/3001/host/willis#newcode59
host/willis:59: (len(lines) == 1 and not re.search(r"\(no branch\)", lines[0])))
:
No space before colon.

[robotboy, 2011-02-01 21:21:51]

Fixed and pushed, thanks.

http://codereview.chromium.org/6409029/diff/3001/host/willis
File host/willis (right):

http://codereview.chromium.org/6409029/diff/3001/host/willis#newcode59
host/willis:59: (len(lines) == 1 and not re.search(r"\(no branch\)", lines[0])))
:
On 2011/02/01 20:55:01, Kenneth Waters wrote:
> No space before colon.

Done.