Issue 6404: Remove the network state notifier and the corresponding DLL. This is likely c...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6404: Remove the network state notifier and the corresponding DLL. This is likely c... (Closed)

Created:
12 years, 2 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove the network state notifier and the corresponding DLL. This is likely causing some startup performance regressions, and we don't really need it now anyway. We should have a different design when we implement this in the future. BUG=3076 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2808

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -61 lines)			Patch
	M	build/internal/essential.vsprops	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	webkit/port/platform/network/NetworkStateNotifierWin.cpp	View		1 chunk	+5 lines, -60 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

12 years, 2 months ago (2008-10-02 20:35:09 UTC) #2

lgtm

http://codereview.chromium.org/6404/diff/1/2
File webkit/port/platform/network/NetworkStateNotifierWin.cpp (right):

http://codereview.chromium.org/6404/diff/1/2#newcode31
Line 31: // Chromium doesn't currently support network state notifications. This
cuases
causes

Expand Messages | Collapse Messages