Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 64003: Fix for invocation over deprecated protocol handler... (Closed)

Created:
11 years, 8 months ago by cpu_(ooo_6.6-7.5)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix for invocation over deprecated protocol handler - We don't support chromehtml protocol anymore and future installers do not register it - Avoid stale registry entries to invoke us BUG=9860 BUG=9862 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13384

Patch Set 1 #

Total comments: 6

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -28 lines) Patch
M chrome/app/chrome_dll_main.cc View 1 2 chunks +8 lines, -28 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
cpu_(ooo_6.6-7.5)
11 years, 8 months ago (2009-04-08 20:39:11 UTC) #1
abarth-chromium
LGTM http://codereview.chromium.org/64003/diff/1/2 File chrome/app/chrome_dll_main.cc (right): http://codereview.chromium.org/64003/diff/1/2#newcode137 Line 137: return (pos == std::wstring::npos) ? false : ...
11 years, 8 months ago (2009-04-08 20:45:23 UTC) #2
cpu_(ooo_6.6-7.5)
http://codereview.chromium.org/64003/diff/1/2 File chrome/app/chrome_dll_main.cc (right): http://codereview.chromium.org/64003/diff/1/2#newcode137 Line 137: return (pos == std::wstring::npos) ? false : true; ...
11 years, 8 months ago (2009-04-08 21:00:23 UTC) #3
Sverrir
Thanks for fixing. http://codereview.chromium.org/64003/diff/1/2 File chrome/app/chrome_dll_main.cc (right): http://codereview.chromium.org/64003/diff/1/2#newcode137 Line 137: return (pos == std::wstring::npos) ? ...
11 years, 8 months ago (2009-04-08 21:16:11 UTC) #4
Sverrir
LGTM btw. Sverrir
11 years, 8 months ago (2009-04-08 21:16:35 UTC) #5
ian fette
Is this patch just looking for chromehtml: anywhere in the string? does that mean that ...
11 years, 8 months ago (2009-04-08 22:21:43 UTC) #6
cpu_(ooo_6.6-7.5)
On 2009/04/08 22:21:43, ian fette wrote: > Is this patch just looking for chromehtml: anywhere ...
11 years, 8 months ago (2009-04-08 23:49:54 UTC) #7
SkyLined
11 years, 8 months ago (2009-04-09 08:20:28 UTC) #8
To fix the problem Ian described, we could look for " chromehtml:" (with a
leading space).

Powered by Google App Engine
This is Rietveld 408576698