Unconditionally run gclient.bat on cygwin, as gyp doesn't work right when...

Unconditionally run gclient.bat on cygwin, as gyp doesn't work right when
run through cygwin python anymore (and fails subtlety).

BUG=None
TEST=None
RS=pkasting


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72718

[Peter Kasting, 2011-01-26 23:57:29]

LGTM

[M-A Ruel, 2011-01-27 00:10:57]

I'd prefer the reverse, why gyp doesn't work on cygwin, due to os.path?

[bradn, 2011-01-27 00:26:08]

Periodically when folks touch the cross platform parts of gyp, they tend to
use '/' instead of os.pathsep for instance. A more robust fix would likely
be to use posixpath throughout the cross-platform parts, and then convert to
\'s in the msvs generator. There was some corner case this didn't work for
early on, so we went the other way. But it certainly would be cleaner if the
input to the generators was expected to be identical regardless of platform
(and if we had small tests on that seam).

At some point I'll fix it, and this time add bots to validate it (there are
gyp trybots and waterfall builds, but no auto-close on breakage, so people
break stuff. I plan to move the gyp stuff to a separate waterfall so I it
can have its own gatekeeper.). But for now it's subtly broken on cygwin (it
doesn't fail, you get rules files in the wrong place amongst other issues).
And I've had 2 people ping me with mysterious problems due to this. This is
just to stop the bleeding.

-BradN

On Wed, Jan 26, 2011 at 4:10 PM, <maruel@chromium.org> wrote:

> I'd prefer the reverse, why gyp doesn't work on cygwin, due to os.path?
>
>
> http://codereview.chromium.org/6400002/
>