Issue 6399002: Clean up Hydrogen's HLoadFunctionPrototype.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6399002: Clean up Hydrogen's HLoadFunctionPrototype. (Closed)

Created:
9 years, 11 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
fschneider

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Clean up Hydrogen's HLoadFunctionPrototype. This instruction was setting an incorrect collection of Changes/Depends flags. Committed: http://code.google.com/p/v8/source/detail?r=6491

Patch Set 1 #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -8 lines)			Patch
	M	src/hydrogen-instructions.h	View		6 chunks	+5 lines, -8 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

It appears that this instruction erroneously reported DependsOnCalls, ChangesInobjectFields, DependsOnInobjectFields. I don't think there was ...

9 years, 11 months ago (2011-01-26 12:04:11 UTC) #1

fschneider

9 years, 11 months ago (2011-01-26 13:26:55 UTC) #2

LGTM.

http://codereview.chromium.org/6399002/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (left):

http://codereview.chromium.org/6399002/diff/1/src/hydrogen-instructions.h#old...
src/hydrogen-instructions.h:2747: virtual bool DataEquals(HValue* other) const {
return true; }
The default implementation of DataEquals is unsafe returning true - maybe making
it unreachable to make sure all instructions that use GVN override it.

Expand Messages | Collapse Messages