Chromium Code Reviews

Issue 6397002: X64 Crankshaft: Reapply reverted operations with DoLoadGlobal disabled. (Closed)

Created:
9 years, 11 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
William Hesse, Rico
CC:
v8-dev
Visibility:
Public.

Description

X64 Crankshaft: Reapply reverted operations with DoLoadGlobal disabled. Committed: http://code.google.com/p/v8/source/detail?r=6510

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix two blocking bugs #

Total comments: 2
Unified diffs Side-by-side diffs Stats (+85 lines, -23 lines)
M src/assembler.h View 2 chunks +1 line, -2 lines 0 comments
M src/x64/deoptimizer-x64.cc View 1 chunk +1 line, -0 lines 0 comments
M src/x64/lithium-codegen-x64.cc View 6 chunks +55 lines, -5 lines 0 comments
M src/x64/lithium-x64.cc View 6 chunks +18 lines, -12 lines 0 comments
M src/x64/macro-assembler-x64.cc View 1 chunk +10 lines, -4 lines 2 comments

Messages

Total messages: 4 (0 generated)
Lasse Reichstein
9 years, 11 months ago (2011-01-26 11:04:31 UTC) #1
Rico
LGTM, maybe we should add: ASSERT(code->safepoint_table_start() - last_pc_offset > 0); To the deoptimizer-x64 (and ia32+arm ...
9 years, 11 months ago (2011-01-27 08:23:02 UTC) #2
Rico
LGTM http://codereview.chromium.org/6397002/diff/4001/src/x64/macro-assembler-x64.cc File src/x64/macro-assembler-x64.cc (right): http://codereview.chromium.org/6397002/diff/4001/src/x64/macro-assembler-x64.cc#newcode1773 src/x64/macro-assembler-x64.cc:1773: if (V8::UseCrankshaft()) { Maybe add the comment from ...
9 years, 11 months ago (2011-01-27 11:52:40 UTC) #3
Lasse Reichstein
9 years, 11 months ago (2011-01-27 11:57:33 UTC) #4 
http://codereview.chromium.org/6397002/diff/4001/src/x64/macro-assembler-x64.cc
File src/x64/macro-assembler-x64.cc (right):

http://codereview.chromium.org/6397002/diff/4001/src/x64/macro-assembler-x64....
src/x64/macro-assembler-x64.cc:1773: if (V8::UseCrankshaft()) {
A comment has been added (without the TODO and "for now") part.

Powered by Google App Engine