Issue 6395007: cashew: gmock integration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6395007: cashew: gmock integration (Closed)

Created:
9 years, 11 months ago by Vince Laviano

Modified:
9 years ago

Reviewers:
Jason Glasgow

CC:
chromium-os-reviews_chromium.org, Vince Laviano

Base URL:
ssh://git@gitrw.chromium.org:9222/cashew.git@master

Visibility:
Public.

Description

cashew: gmock integration Separate interfaces from impls to support creation of mock ServiceManager, Service, and Device objects. Integrate gmock (Google C++ Mocking Framework). Remove glib integration from public interfaces. BUG=chromium-os:7775 TEST=unit tests (FEATURES=test emerge-<board> cashew) Change-Id: I46156233836468d319710e578e9a08427964b7eb Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=cb803e8

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2477 lines, -2211 lines)			Patch
M	configure.ac	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/Makefile.am	View	4 chunks	+15 lines, -1 line	0 comments	Download
M	src/cashew_unittest.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/device.h	View	3 chunks	+16 lines, -119 lines	0 comments	Download
M	src/device.cc	View	2 chunks	+7 lines, -359 lines	0 comments	Download
A	src/device_impl.h	View	1 chunk	+135 lines, -0 lines	0 comments	Download
A	src/device_impl.cc	View	1 chunk	+356 lines, -0 lines	0 comments	Download
A	src/device_mock.h	View	1 chunk	+29 lines, -0 lines	0 comments	Download
M	src/main.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/service.h	View	7 chunks	+21 lines, -220 lines	0 comments	Download
M	src/service.cc	View	2 chunks	+8 lines, -922 lines	0 comments	Download
A	src/service_impl.h	View	1 chunk	+255 lines, -0 lines	0 comments	Download
A	src/service_impl.cc	View	1 chunk	+923 lines, -0 lines	0 comments	Download
M	src/service_manager.h	View	5 chunks	+15 lines, -139 lines	0 comments	Download
M	src/service_manager.cc	View	2 chunks	+10 lines, -448 lines	0 comments	Download
A	src/service_manager_impl.h	View	1 chunk	+165 lines, -0 lines	0 comments	Download
A	src/service_manager_impl.cc	View	1 chunk	+453 lines, -0 lines	0 comments	Download
A	src/service_manager_mock.h	View	1 chunk	+29 lines, -0 lines	0 comments	Download
A	src/service_mock.h	View	1 chunk	+34 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vince Laviano

Related CL to update ebuild: http://codereview.chromium.org/6273019/

9 years, 11 months ago (2011-01-27 21:55:44 UTC) #1

Jason Glasgow

9 years, 11 months ago (2011-01-28 19:19:57 UTC) #2

LGTM after offline discussion of interface choices.

Expand Messages | Collapse Messages