Issue 6394004: Log source ip and port in NetLog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6394004: Log source ip and port in NetLog. (Closed)

Created:
9 years, 11 months ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
Mike Belshe

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Log source ip and port in NetLog. This will make it easier to identify specific TCP connections in a wireshark trace. BUG=70649 TEST=Connect somewhere, check about:net-internals to see that source ip and port are logged. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72607

Patch Set 1 #

Patch Set 2 : Logging #

Patch Set 3 : Refactor. #

Patch Set 4 : Fix DCHECK. #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+126 lines, -30 lines)			Patch
M	net/base/net_util.h	View		3 chunks	+16 lines, -2 lines	0 comments	Download
M	net/base/net_util.cc	View	1 2 3	7 chunks	+50 lines, -20 lines	0 comments	Download
M	net/socket/tcp_client_socket_libevent.cc	View	1 2	2 chunks	+31 lines, -4 lines	0 comments	Download
M	net/socket/tcp_client_socket_win.cc	View	1 2	1 chunk	+29 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages