Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 6393007: ARM: Make the ARM hardware builder green... (Closed)

Created:
9 years, 11 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

ARM: Make the ARM hardware builder green Fix a bug in the --debug-code alignment check in the C entry stub. Don't force the --debug-code flag in the ARM disassembler tests. The framework does support passing flags and the test runner will when running tests in debug mode. Skip some deserialization tests which crashes from time to time. Committed: http://code.google.com/p/v8/source/detail?r=6484

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/cctest.status View 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
9 years, 11 months ago (2011-01-26 09:29:06 UTC) #1
Mads Ager (chromium)
9 years, 11 months ago (2011-01-26 09:39:55 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698