Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 6393002: Fix major layout breakage in the language selection overlay on Chrome OS (Closed)

Created:
9 years, 11 months ago by satorux1
Modified:
9 years, 7 months ago
Reviewers:
James Hawkins, kochi
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Fix major layout breakage in the language selection overlay on Chrome OS For the record, the layout was broken due to the two changes: http://src.chromium.org/viewvc/chrome?view=rev&revision=71836 caused each language name to have a weird button-like shadow. http://src.chromium.org/viewvc/chrome?view=rev&revision=72085 broke the two-column layout. BUG=crosbug.com/11241 TEST=on chrome os, open the language selection overlay. confirm that the layout is nice. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72472

Patch Set 1 #

Patch Set 2 : minor cleanup #

Total comments: 3

Patch Set 3 : minor cleanup #

Patch Set 4 : minor cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M chrome/browser/resources/options/language_options.css View 1 2 3 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/resources/options/options_page.css View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
satorux1
9 years, 11 months ago (2011-01-25 07:21:52 UTC) #1
kochi
http://codereview.chromium.org/6393002/diff/2001/chrome/browser/resources/options/options_page.css File chrome/browser/resources/options/options_page.css (right): http://codereview.chromium.org/6393002/diff/2001/chrome/browser/resources/options/options_page.css#newcode370 chrome/browser/resources/options/options_page.css:370: background: transparent none; background: transparent; background-image: none; ?
9 years, 11 months ago (2011-01-25 07:24:56 UTC) #2
satorux1
http://codereview.chromium.org/6393002/diff/2001/chrome/browser/resources/options/options_page.css File chrome/browser/resources/options/options_page.css (right): http://codereview.chromium.org/6393002/diff/2001/chrome/browser/resources/options/options_page.css#newcode370 chrome/browser/resources/options/options_page.css:370: background: transparent none; On 2011/01/25 07:24:56, Takayoshi Kochi wrote: ...
9 years, 11 months ago (2011-01-25 07:35:43 UTC) #3
kochi
9 years, 11 months ago (2011-01-25 07:39:51 UTC) #4
LGTM

http://codereview.chromium.org/6393002/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options/options_page.css (right):

http://codereview.chromium.org/6393002/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/options_page.css:370: background: transparent
none;
I see, thanks for the explanation.

I learn some new CSS stuff every day...

Powered by Google App Engine
This is Rietveld 408576698