Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7014)

Unified Diff: chrome/renderer/spellchecker/spellcheck_provider_unittest.cc

Issue 6392045: Integrating Mac OS Grammar checker into Chromium. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updated to ToT Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/spellchecker/spellcheck_provider.cc ('k') | webkit/glue/webpreferences.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/spellchecker/spellcheck_provider_unittest.cc
diff --git a/chrome/renderer/spellchecker/spellcheck_provider_unittest.cc b/chrome/renderer/spellchecker/spellcheck_provider_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..bb63f19727b28a86d61afd0822b5fff05bb9bb01
--- /dev/null
+++ b/chrome/renderer/spellchecker/spellcheck_provider_unittest.cc
@@ -0,0 +1,178 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <vector>
+
+#include "base/utf_string_conversions.h"
+#include "chrome/common/render_messages.h"
+#include "chrome/renderer/spellchecker/spellcheck_provider.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebTextCheckingCompletion.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebTextCheckingResult.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebVector.h"
+
+namespace {
+
+// Faked test target, which stores sent message for verification,
+// and allows manipulate |is_using_platform_spelling_engine| parameter.
+class TestingSpellCheckProvider : public SpellCheckProvider {
+ public:
+ TestingSpellCheckProvider()
+ : SpellCheckProvider(NULL, NULL),
+ is_using_platform_spelling_engine_(true) {
+ }
+
+ virtual ~TestingSpellCheckProvider() {
+ for (std::vector<IPC::Message*>::iterator i = messages_.begin();
+ i != messages_.end();
+ ++i) {
+ delete *i;
+ }
+ }
+
+ virtual bool Send(IPC::Message* message) {
+ messages_.push_back(message);
+ return true;
+ }
+
+ virtual bool is_using_platform_spelling_engine() const {
+ return is_using_platform_spelling_engine_;
+ }
+
+ std::vector<IPC::Message*> messages_;
+ bool is_using_platform_spelling_engine_;
+};
+
+// A fake completion object for verification.
+class FakeTextCheckingCompletion : public WebKit::WebTextCheckingCompletion {
+ public:
+ FakeTextCheckingCompletion()
+ : completion_count_(0) {
+ }
+
+ virtual void didFinishCheckingText(
+ const WebKit::WebVector<WebKit::WebTextCheckingResult>& results) {
+ completion_count_++;
+ last_results_ = results;
+ }
+
+ size_t completion_count_;
+ WebKit::WebVector<WebKit::WebTextCheckingResult> last_results_;
+};
+
+class SpellCheckProviderTest : public testing::Test {
+ public:
+ SpellCheckProviderTest() { }
+ virtual ~SpellCheckProviderTest() { }
+
+ protected:
+ TestingSpellCheckProvider provider_;
+};
+
+struct MessageParameters {
+ MessageParameters()
+ : router_id(0),
+ request_id(0),
+ document_tag(0) { }
+
+ int router_id;
+ int request_id;
+ int document_tag;
+ string16 text;
+};
+
+MessageParameters ReadPlatformRequestTextCheck(IPC::Message* message) {
+ MessageParameters parameters;
+ bool ok = ViewHostMsg_SpellChecker_PlatformRequestTextCheck::Read(
+ message,
+ &parameters.router_id,
+ &parameters.request_id,
+ &parameters.document_tag,
+ &parameters.text);
+ EXPECT_TRUE(ok);
+ return parameters;
+}
+
+void FakeMessageArrival(SpellCheckProvider* provider,
+ const MessageParameters& parameters) {
+ std::vector<WebKit::WebTextCheckingResult> fake_result;
+ bool handled = provider->OnMessageReceived(
+ ViewMsg_SpellChecker_RespondTextCheck
+ (0,
+ parameters.request_id,
+ parameters.document_tag,
+ fake_result));
+ EXPECT_TRUE(handled);
+}
+
+TEST_F(SpellCheckProviderTest, SingleRoundtripSuccess) {
+ FakeTextCheckingCompletion completion;
+ int document_tag = 123;
+
+ provider_.RequestTextChecking(WebKit::WebString("hello"),
+ document_tag,
+ &completion);
+ EXPECT_EQ(completion.completion_count_, 0U);
+ EXPECT_EQ(provider_.messages_.size(), 1U);
+ EXPECT_EQ(provider_.pending_text_request_size(), 1U);
+
+ MessageParameters read_parameters =
+ ReadPlatformRequestTextCheck(provider_.messages_[0]);
+ EXPECT_EQ(read_parameters.text, UTF8ToUTF16("hello"));
+
+ FakeMessageArrival(&provider_, read_parameters);
+ EXPECT_EQ(completion.completion_count_, 1U);
+ EXPECT_EQ(provider_.pending_text_request_size(), 0U);
+}
+
+TEST_F(SpellCheckProviderTest, TwoRoundtripSuccess) {
+ int document_tag = 123;
+
+ FakeTextCheckingCompletion completion1;
+ provider_.RequestTextChecking(WebKit::WebString("hello"),
+ document_tag,
+ &completion1);
+ FakeTextCheckingCompletion completion2;
+ provider_.RequestTextChecking(WebKit::WebString("bye"),
+ document_tag,
+ &completion2);
+
+ EXPECT_EQ(completion1.completion_count_, 0U);
+ EXPECT_EQ(completion2.completion_count_, 0U);
+ EXPECT_EQ(provider_.messages_.size(), 2U);
+ EXPECT_EQ(provider_.pending_text_request_size(), 2U);
+
+ MessageParameters read_parameters1 =
+ ReadPlatformRequestTextCheck(provider_.messages_[0]);
+ EXPECT_EQ(read_parameters1.text, UTF8ToUTF16("hello"));
+
+ MessageParameters read_parameters2 =
+ ReadPlatformRequestTextCheck(provider_.messages_[1]);
+ EXPECT_EQ(read_parameters2.text, UTF8ToUTF16("bye"));
+
+ FakeMessageArrival(&provider_, read_parameters1);
+ EXPECT_EQ(completion1.completion_count_, 1U);
+ EXPECT_EQ(completion2.completion_count_, 0U);
+ EXPECT_EQ(provider_.pending_text_request_size(), 1U);
+
+ FakeMessageArrival(&provider_, read_parameters2);
+ EXPECT_EQ(completion1.completion_count_, 1U);
+ EXPECT_EQ(completion2.completion_count_, 1U);
+ EXPECT_EQ(provider_.pending_text_request_size(), 0U);
+}
+
+TEST_F(SpellCheckProviderTest, PlatformEngineUnavailable) {
+ provider_.is_using_platform_spelling_engine_ = false;
+
+ int document_tag = 123;
+ FakeTextCheckingCompletion completion;
+ provider_.RequestTextChecking(WebKit::WebString("hello"),
+ document_tag,
+ &completion);
+ EXPECT_EQ(completion.completion_count_, 1U);
+ EXPECT_EQ(provider_.messages_.size(), 0U);
+ EXPECT_EQ(provider_.pending_text_request_size(), 0U);
+}
+
+} // namespace
« no previous file with comments | « chrome/renderer/spellchecker/spellcheck_provider.cc ('k') | webkit/glue/webpreferences.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698