Integrating Mac OS Grammar checker into Chromium.

chrome/renderer/render_view.h

Index: chrome/renderer/render_view.h
diff --git a/chrome/renderer/render_view.h b/chrome/renderer/render_view.h
index 6a57a03430cc1839b298b6af2b1c70ab970a31e0..8ca3106da13bedf26980dc312ef038cd0a7d8222 100644
--- a/chrome/renderer/render_view.h
+++ b/chrome/renderer/render_view.h
@@ -16,6 +16,7 @@
 #include "app/surface/transport_dib.h"
 #include "base/basictypes.h"
 #include "base/gtest_prod_util.h"
+#include "base/id_map.h"
 #include "base/linked_ptr.h"
 #include "base/observer_list.h"
 #include "base/timer.h"
@@ -417,6 +418,9 @@ class RenderView : public RenderWidget,
   virtual void spellCheck(const WebKit::WebString& text,
                           int& offset,
                           int& length);
+  virtual void requestCheckingOfText(
+      const WebKit::WebString& text,
+      WebKit::WebTextCheckingCompletion* completion);
   virtual WebKit::WebString autoCorrectWord(
       const WebKit::WebString& misspelled_word);
   virtual void showSpellingUI(bool show);
@@ -475,8 +479,9 @@ class RenderView : public RenderWidget,
   virtual WebKit::WebPlugin* createPlugin(
       WebKit::WebFrame* frame,
       const WebKit::WebPluginParams& params);
-  virtual WebKit::WebWorker* createWorker(WebKit::WebFrame* frame,
-                                          WebKit::WebWorkerClient* client);
+  virtual WebKit::WebWorker* createWorker(
+      WebKit::WebFrame* frame,
+      WebKit::WebWorkerClient* client);

[Hironori Bono, 2011/02/09 05:43:51]

nit: is this change needed by your change?

[gmorrita, 2011/02/10 02:15:21]

Hmm. Something wrong happened. Recovered original.

   virtual WebKit::WebSharedWorker* createSharedWorker(
       WebKit::WebFrame* frame, const WebKit::WebURL& url,
       const WebKit::WebString& name, unsigned long long documentId);
@@ -694,6 +699,7 @@ class RenderView : public RenderWidget,
 
   typedef std::map<GURL, ContentSettings> HostContentSettings;
   typedef std::map<GURL, double> HostZoomLevels;
+  typedef IDMap<WebKit::WebTextCheckingCompletion> TextCheckCompletions;
 
   // Cannot use std::set unfortunately since linked_ptr<> does not support
   // operator<.
@@ -935,6 +941,13 @@ class RenderView : public RenderWidget,
   void OnThemeChanged();
   void OnToggleSpellCheck();
   void OnToggleSpellPanel(bool is_currently_visible);
+  void OnRespondTextCheck(int identifier, int tag,
+                          const TextCheckingResultList& results);
+  void OnTranslatePage(int page_id,

[Hironori Bono, 2011/02/09 05:43:51]

nit: is this function needed by your change?

[gmorrita, 2011/02/10 02:15:21]

No... thank you for pointing this out. Removed.
Something wrong happened on updating the patch.

+                       const std::string& translate_script,
+                       const std::string& source_lang,
+                       const std::string& target_lang);
+
   void OnUndo();
   void OnUpdateBrowserWindowId(int window_id);
   void OnUpdateTargetURLAck();
@@ -1455,6 +1468,10 @@ class RenderView : public RenderWidget,
   // is fine.
   ObserverList<RenderViewObserver> observers_;
 
+  // Holding ongoing spellchecking operations, assigning IDs

[Hironori Bono, 2011/02/09 05:43:51]

nit: "holding" -> "holds", "assigning" -> "assigns". a variable comment should
be descriptive, i.e. the subject of a variable comment should be the variable
itself.
<http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Variab...>

[gmorrita, 2011/02/10 02:15:21]

Thanks for the clarification. Fixed.

+  // for the IPC routing.
+  TextCheckCompletions text_check_completions_;
+
   // ---------------------------------------------------------------------------
   // ADDING NEW DATA? Please see if it fits appropriately in one of the above
   // sections rather than throwing it randomly at the end. If you're adding a