Integrating Mac OS Grammar checker into Chromium.

chrome/renderer/render_view.h

Index: chrome/renderer/render_view.h
diff --git a/chrome/renderer/render_view.h b/chrome/renderer/render_view.h
index 45ef7260fb6917b6d1fb24f3d13f572e4314bcc3..91c7c750c5ce9ab46433de8cc2ce09b0997b5627 100644
--- a/chrome/renderer/render_view.h
+++ b/chrome/renderer/render_view.h
@@ -16,6 +16,7 @@
 #include "app/surface/transport_dib.h"
 #include "base/basictypes.h"
 #include "base/gtest_prod_util.h"
+#include "base/id_map.h"
 #include "base/linked_ptr.h"
 #include "base/observer_list.h"
 #include "base/timer.h"
@@ -139,6 +140,7 @@ class WebPlugin;
 class WebSpeechInputController;
 class WebSpeechInputListener;
 class WebStorageNamespace;
+class WebTextCheckingResult;
 class WebURLRequest;
 class WebView;
 struct WebContextMenuData;
@@ -418,6 +420,9 @@ class RenderView : public RenderWidget,
   virtual void spellCheck(const WebKit::WebString& text,
                           int& offset,
                           int& length);
+  virtual void requestCheckingOfText(

[pink (ping after 24hrs), 2011/02/11 17:33:40]

I'd call this |-requestTextChecking|. It's more in line with the naming
elsewhere.

[gmorrita, 2011/02/17 11:39:44]

I cannot change the name
because this API overrides a WebKit-provided abstract class.
(The name comes from Cocoa thing.)

+      const WebKit::WebString& text,
+      WebKit::WebTextCheckingCompletion* completion);
   virtual WebKit::WebString autoCorrectWord(
       const WebKit::WebString& misspelled_word);
   virtual void showSpellingUI(bool show);
@@ -687,6 +692,7 @@ class RenderView : public RenderWidget,
 
   typedef std::map<GURL, ContentSettings> HostContentSettings;
   typedef std::map<GURL, double> HostZoomLevels;
+  typedef IDMap<WebKit::WebTextCheckingCompletion> TextCheckCompletions;
 
   // Cannot use std::set unfortunately since linked_ptr<> does not support
   // operator<.
@@ -928,6 +934,11 @@ class RenderView : public RenderWidget,
   void OnThemeChanged();
   void OnToggleSpellCheck();
   void OnToggleSpellPanel(bool is_currently_visible);
+  void OnRespondTextCheck(
+      int identifier,
+      int tag,
+      const std::vector<WebKit::WebTextCheckingResult>& results);
+
   void OnUndo();
   void OnUpdateBrowserWindowId(int window_id);
   void OnUpdateTargetURLAck();
@@ -1448,6 +1459,10 @@ class RenderView : public RenderWidget,
   // is fine.
   ObserverList<RenderViewObserver> observers_;
 
+  // Holds ongoing spellchecking operations, assigns IDs

[pink (ping after 24hrs), 2011/02/11 17:33:40]

dont wrap early. Put as much of the comment on this line as possible before
wrapping.

[gmorrita, 2011/02/17 11:39:44]

Done.

+  // for the IPC routing.
+  TextCheckCompletions text_check_completions_;
+
   // ---------------------------------------------------------------------------
   // ADDING NEW DATA? Please see if it fits appropriately in one of the above
   // sections rather than throwing it randomly at the end. If you're adding a