Integrating Mac OS Grammar checker into Chromium.

chrome/browser/spellchecker_mac.mm

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file implements the interface defined in spellchecker_platform_engine.h
 // for the OS X platform.
 
 #include "chrome/browser/spellchecker_platform_engine.h"
 
 #import <Cocoa/Cocoa.h>
@@ skipping 190 matching lines @@
   return static_cast<int>(doc_tag);
 }
 
 void IgnoreWord(const string16& word) {
   [[NSSpellChecker sharedSpellChecker] ignoreWord:base::SysUTF16ToNSString(word)
                            inSpellDocumentWithTag:last_seen_tag_];
 }
 
 void CloseDocumentWithTag(int tag) {
   [[NSSpellChecker sharedSpellChecker]
-      closeSpellDocumentWithTag:static_cast<NSInteger>(tag)];
+    closeSpellDocumentWithTag:static_cast<NSInteger>(tag)];
+}
+
+

[Hironori Bono, 2011/02/09 05:43:51]

nit: need one line-break between functions.

[gmorrita, 2011/02/10 02:15:21]

Done.

+void RequestTextCheck(
+    const string16& text, int tag,
+    Callback1<const TextCheckingResultList&>::Type* callback) {

[Hironori Bono, 2011/02/09 05:43:51]

nit: align parameters if possible.

[gmorrita, 2011/02/10 02:15:21]

Done.

+  // TODO(morrita): Use [NSSpellChecker requestCheckingOfString]
+  // when the build target goes upto 10.6
+  TextCheckingResultList check_results;
+  NSString* text_to_check = base::SysUTF16ToNSString(text);
+  size_t startingAt = 0;

[Hironori Bono, 2011/02/09 05:43:51]

nit: variable names are all lowercase.
<http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Variab...>

[gmorrita, 2011/02/10 02:15:21]

Done.

+  while (startingAt < text.size()) {
+    NSRange range = [[NSSpellChecker sharedSpellChecker]
+                      checkSpellingOfString:text_to_check startingAt:startingAt
+                      language:nil wrap:NO inSpellDocumentWithTag:tag
+                      wordCount:NULL];

[Hironori Bono, 2011/02/09 05:43:51]

If I understand this change correctly, this code is run on the IPC thread, i.e.
Chrome cannot process any IPC messages while this function is checking the given
text. It may be better to create a Task object and post it to the I/O thread?
('src/chrome/browser/renderer_host/render_message_filter_mac.mm' is an example
of how to create a task and post it.)

[gmorrita, 2011/02/10 02:15:21]

Certainly.
So I extracted the check into a task class.

+    if (0 == range.length)
+      break;
+    check_results.push_back(TextCheckingResult(
+        TextCheckingResult::MISSPELLING, range.location, range.length));
+    startingAt = range.location + range.length;
+  }
+
+  callback->Run(check_results);
+  delete callback;
 }
 
 }  // namespace SpellCheckerPlatform