Issue 6392034: Move cros_overlay_list to src/platform/dev.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6392034: Move cros_overlay_list to src/platform/dev. (Closed)

Created:
9 years, 10 months ago by robotboy

Modified:
9 years, 7 months ago

Reviewers:
davidjames, scottz, anush

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git@master

Visibility:
Public.

Description

Move cros_overlay_list to src/platform/dev. This is step 3/3, after cros_overlay_list is added to dev, and after the ebuilds are updated to install from dev and not crosutils, then this can go in. Change-Id: I8ae26938fb14ccf6737acd9ca99b58aaf65a1aca BUG=chromium-os:11507 TEST=None Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=fd135cd

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -158 lines)			Patch
	D	bin/cros_overlay_list	View		1 chunk	+0 lines, -158 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

anush

9 years, 10 months ago (2011-02-01 22:02:41 UTC) #2

LGTM after others are committed.

On Tue, Feb 1, 2011 at 12:34 PM, <robotboy@chromium.org> wrote:

> Reviewers: scottz, anush, davidjames,
>
> Description:
> Move cros_overlay_list to src/platform/dev.
>
> This is step 3/3, after cros_overlay_list is added to dev, and
> after the ebuilds are updated to install from dev and not
> crosutils, then this can go in.
>
> Change-Id: I8ae26938fb14ccf6737acd9ca99b58aaf65a1aca
>
> BUG=chromium-os:11507
> TEST=None
>
> Please review this at http://codereview.chromium.org/6392034/
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/crosutils.git@master
>
> Affected files:
>  D bin/cros_overlay_list
>
>
>

Expand Messages | Collapse Messages