Issue 6392027: Change OSR stack check patching to use the stack check table.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6392027: Change OSR stack check patching to use the stack check table. (Closed)

Created:
9 years, 10 months ago by Karl Klose

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Change OSR stack check patching to use the stack check table. Change OSR stack check patching to use the stack check table to iterate over the calls to stack guards platform independent. Introduce Deoptimizer::PatchStackCheckAt for each platform to perform the platform specific patch at a given pc. BUG=none TEST=none

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address comments. #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -48 lines)			Patch
M	src/arm/deoptimizer-arm.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/deoptimizer.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/deoptimizer.cc	View		1 chunk	+19 lines, -0 lines	0 comments	Download
M	src/ia32/deoptimizer-ia32.cc	View	1	1 chunk	+29 lines, -42 lines	0 comments	Download
M	src/x64/deoptimizer-x64.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 10 months ago (2011-02-01 10:24:04 UTC) #2

LGTM with a couple of fomatting nits.

http://codereview.chromium.org/6392027/diff/1/src/ia32/deoptimizer-ia32.cc
File src/ia32/deoptimizer-ia32.cc (right):

http://codereview.chromium.org/6392027/diff/1/src/ia32/deoptimizer-ia32.cc#ne...
src/ia32/deoptimizer-ia32.cc:112: Address call_target_address = pc_after -
kIntSize;
This is really kPointerSize.

http://codereview.chromium.org/6392027/diff/1/src/ia32/deoptimizer-ia32.cc#ne...
src/ia32/deoptimizer-ia32.cc:113: ASSERT(check_code->entry() ==
Assembler::target_address_at(
I would format this differently:

ASSERT(check_code->entry() ==
       Assembler::target_address_at(call_target_address));

http://codereview.chromium.org/6392027/diff/1/src/ia32/deoptimizer-ia32.cc#ne...
src/ia32/deoptimizer-ia32.cc:137: replacement_code->entry());
Align with the other argument please.

Assembler::set_target_address(arg0,
                              arg1);

Expand Messages | Collapse Messages