Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/stub-cache.h

Issue 6392003: Minor cleanup: Use MaybeObject instead of bool and Failure** in... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/stub-cache-ia32.cc ('k') | src/x64/stub-cache-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 483 matching lines...) Expand 10 before | Expand all | Expand 10 after
494 void GenerateLoadField(JSObject* object, 494 void GenerateLoadField(JSObject* object,
495 JSObject* holder, 495 JSObject* holder,
496 Register receiver, 496 Register receiver,
497 Register scratch1, 497 Register scratch1,
498 Register scratch2, 498 Register scratch2,
499 Register scratch3, 499 Register scratch3,
500 int index, 500 int index,
501 String* name, 501 String* name,
502 Label* miss); 502 Label* miss);
503 503
504 bool GenerateLoadCallback(JSObject* object, 504 MaybeObject* GenerateLoadCallback(JSObject* object,
505 JSObject* holder, 505 JSObject* holder,
506 Register receiver, 506 Register receiver,
507 Register name_reg, 507 Register name_reg,
508 Register scratch1, 508 Register scratch1,
509 Register scratch2, 509 Register scratch2,
510 Register scratch3, 510 Register scratch3,
511 AccessorInfo* callback, 511 AccessorInfo* callback,
512 String* name, 512 String* name,
513 Label* miss, 513 Label* miss);
514 Failure** failure);
515 514
516 void GenerateLoadConstant(JSObject* object, 515 void GenerateLoadConstant(JSObject* object,
517 JSObject* holder, 516 JSObject* holder,
518 Register receiver, 517 Register receiver,
519 Register scratch1, 518 Register scratch1,
520 Register scratch2, 519 Register scratch2,
521 Register scratch3, 520 Register scratch3,
522 Object* value, 521 Object* value,
523 String* name, 522 String* name,
524 Label* miss); 523 Label* miss);
(...skipping 286 matching lines...) Expand 10 before | Expand all | Expand 10 after
811 MUST_USE_RESULT MaybeObject* CompileKeyedStoreStub( 810 MUST_USE_RESULT MaybeObject* CompileKeyedStoreStub(
812 ExternalArrayType array_type, Code::Flags flags); 811 ExternalArrayType array_type, Code::Flags flags);
813 812
814 private: 813 private:
815 MaybeObject* GetCode(Code::Flags flags); 814 MaybeObject* GetCode(Code::Flags flags);
816 }; 815 };
817 816
818 } } // namespace v8::internal 817 } } // namespace v8::internal
819 818
820 #endif // V8_STUB_CACHE_H_ 819 #endif // V8_STUB_CACHE_H_
OLDNEW
« no previous file with comments | « src/ia32/stub-cache-ia32.cc ('k') | src/x64/stub-cache-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698