Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: presubmit_canned_checks.py

Issue 6391001: Don't prompt developers to add blank test= or bug= lines. (Closed) Base URL: svn://chrome-svn/chrome/trunk/tools/depot_tools/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit_canned_checks.py
===================================================================
--- presubmit_canned_checks.py (revision 72347)
+++ presubmit_canned_checks.py (working copy)
@@ -12,7 +12,8 @@
return []
else:
return [output_api.PresubmitNotifyResult(
- 'Changelist should have a TEST= field. TEST=none is allowed.')]
+ 'If this change requires manual test instructions to QA team, add '
+ 'TEST=[instructions].')]
def CheckChangeHasBugField(input_api, output_api):
@@ -21,7 +22,7 @@
return []
else:
return [output_api.PresubmitNotifyResult(
- 'Changelist should have a BUG= field. BUG=none is allowed.')]
+ 'If this change has an associated bug, add BUG=[bug number].')]
def CheckChangeHasTestedField(input_api, output_api):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698