Issue 6389003: DOMUI/CrOS: Set an empty sync action link label (which has the result of hiding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6389003: DOMUI/CrOS: Set an empty sync action link label (which has the result of hiding (Closed)

Created:
9 years, 11 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
csilv

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

DOMUI/CrOS: Set an empty sync action link label (which has the result of hiding the button). BUG=chromium-os:11195 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72531

Patch Set 2 : Review fix. #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
	M	chrome/browser/dom_ui/options/personal_options_handler.cc	View	1	2 chunks	+10 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

csilv

LGTM http://codereview.chromium.org/6389003/diff/1/chrome/browser/dom_ui/options/personal_options_handler.cc File chrome/browser/dom_ui/options/personal_options_handler.cc (right): http://codereview.chromium.org/6389003/diff/1/chrome/browser/dom_ui/options/personal_options_handler.cc#newcode262 chrome/browser/dom_ui/options/personal_options_handler.cc:262: visible.reset(Value::CreateBooleanValue(false)); suggestion: put the visible.reset() line in an ...

9 years, 11 months ago (2011-01-25 20:00:49 UTC) #2

James Hawkins

9 years, 11 months ago (2011-01-25 20:05:08 UTC) #3

http://codereview.chromium.org/6389003/diff/1/chrome/browser/dom_ui/options/p...
File chrome/browser/dom_ui/options/personal_options_handler.cc (right):

http://codereview.chromium.org/6389003/diff/1/chrome/browser/dom_ui/options/p...
chrome/browser/dom_ui/options/personal_options_handler.cc:262:
visible.reset(Value::CreateBooleanValue(false));
On 2011/01/25 20:00:49, csilv wrote:
> suggestion: put the visible.reset() line in an #if defined (OS_CHROMEOS)
block,
> and remove the javascript call from the conditional since it's the same for
both
> conditions.

Done.

Expand Messages | Collapse Messages

Issue 6389003: DOMUI/CrOS: Set an empty sync action link label (which has the result of hiding (Closed)

Description

Patch Set 1 #

Patch Set 2 : Review fix. #

Messages