Add heuristics to skip thumbnail generation when it's unnecessary.

chrome/common/thumbnail_score.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/thumbnail_score.h"
 
 #include "base/logging.h"
+#include "base/stringprintf.h"
 
 using base::Time;
 using base::TimeDelta;
 
 const TimeDelta ThumbnailScore::kUpdateThumbnailTime = TimeDelta::FromDays(1);
 const double ThumbnailScore::kThumbnailMaximumBoringness = 0.94;
+// Per crbug.com/65936#c4, 91.83% of thumbnail scores are less than 0.70.
+const double ThumbnailScore::kThumbnailInterestingEnoughBoringness = 0.70;
 const double ThumbnailScore::kThumbnailDegradePerHour = 0.01;
 
 // Calculates a numeric score from traits about where a snapshot was
 // taken. We store the raw components in the database because I'm sure
 // this will evolve and I don't want to break databases.
 static int GetThumbnailType(bool good_clipping, bool at_top) {
   if (good_clipping && at_top) {
     return 0;
   } else if (good_clipping && !at_top) {
     return 1;
@@ skipping 39 matching lines @@
   // When testing equality we use ToTimeT() because that's the value
   // stuck in the SQL database, so we need to test equivalence with
   // that lower resolution.
   return boring_score == rhs.boring_score &&
       good_clipping == rhs.good_clipping &&
       at_top == rhs.at_top &&
       time_at_snapshot.ToTimeT() == rhs.time_at_snapshot.ToTimeT() &&
       redirect_hops_from_dest == rhs.redirect_hops_from_dest;
 }
 
+std::string ThumbnailScore::ToString() const {
+  return StringPrintf("boring_score: %f, at_top %d, good_clipping %d, "
+                      "time_at_snapshot: %f, redirect_hops_from_dest: %d",
+                      boring_score,
+                      at_top,
+                      good_clipping,
+                      time_at_snapshot.ToDoubleT(),
+                      redirect_hops_from_dest);
+}
+
 bool ShouldReplaceThumbnailWith(const ThumbnailScore& current,
                                 const ThumbnailScore& replacement) {
   int current_type = GetThumbnailType(current.good_clipping, current.at_top);
   int replacement_type = GetThumbnailType(replacement.good_clipping,
                                           replacement.at_top);
   if (replacement_type < current_type) {
     // If we have a better class of thumbnail, add it if it meets
     // certain minimum boringness.
     return replacement.boring_score <
         ThumbnailScore::kThumbnailMaximumBoringness;
@@ skipping 26 matching lines @@
     if (replacement_interesting_score > current_interesting_score)
       return true;
   }
 
   // If the current thumbnail doesn't meet basic boringness
   // requirements, but the replacement does, always replace the
   // current one even if we're using a worse thumbnail type.
   return current.boring_score >= ThumbnailScore::kThumbnailMaximumBoringness &&
       replacement.boring_score < ThumbnailScore::kThumbnailMaximumBoringness;
 }
+
+bool ShouldGenerateThumbnail(const ThumbnailScore& current) {
+  const TimeDelta time_elapsed = Time::Now() - current.time_at_snapshot;
+  // Consider the current thumbnail to be new and interesting enough if
+  // the following critera are met.
+  const bool new_and_interesting_enough =
+      (time_elapsed < ThumbnailScore::kUpdateThumbnailTime &&
+       current.good_clipping && current.at_top &&
+       current.boring_score <
+       ThumbnailScore::kThumbnailInterestingEnoughBoringness);
+  return !new_and_interesting_enough;

[brettw, 2011/01/26 05:55:20]

Can you add a comment here like "We want to generate a new thumbnail when the
old thumbnail is sufficiently old or uninteresting." It took me a minute to
figure out why you're inverting the condition here.

[satorux1, 2011/01/26 08:14:46]

Good point. Done.

+}