Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 6388003: Another fix for leaking error objects. User code can overwrite (Closed)

Created:
9 years, 11 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Another fix for leaking error objects. User code can overwrite ReferenceError.prototype.__proto__ which will make "error instanceof Error" fail. However, the ReferenceError.prototype object itself cannot be modified. Therefore, the error checks must check for concrete error instances instead of only checking for Error. Committed: http://code.google.com/p/v8/source/detail?r=6450

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M src/messages.js View 1 chunk +17 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
9 years, 11 months ago (2011-01-25 07:43:06 UTC) #1
Søren Thygesen Gjesse
9 years, 11 months ago (2011-01-25 08:48:13 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698