Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Side by Side Diff: ipc/ipc_test_sink.cc

Issue 6387007: Add support for attaching filters to an IPC TestSink. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address Brett's suggestions Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ipc/ipc_test_sink.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ipc/ipc_test_sink.h" 5 #include "ipc/ipc_test_sink.h"
6 6
7 #include "ipc/ipc_message.h" 7 #include "ipc/ipc_message.h"
8 8
9 namespace IPC { 9 namespace IPC {
10 10
11 TestSink::TestSink() { 11 TestSink::TestSink() {
12 } 12 }
13 13
14 TestSink::~TestSink() { 14 TestSink::~TestSink() {
15 } 15 }
16 16
17 bool TestSink::Send(Message* message) { 17 bool TestSink::Send(Message* message) {
18 OnMessageReceived(*message); 18 OnMessageReceived(*message);
19 delete message; 19 delete message;
20 return true; 20 return true;
21 } 21 }
22 22
23 bool TestSink::OnMessageReceived(const Message& msg) { 23 bool TestSink::OnMessageReceived(const Message& msg) {
24 ObserverListBase<Channel::Listener>::Iterator it(filter_list_);
25 Channel::Listener* observer;
26 while ((observer = it.GetNext()) != NULL)
brettw 2011/01/28 21:12:32 This outer while() needs {} since it contains > 1
Brian Ryner 2011/01/28 22:04:23 Done.
27 if (observer->OnMessageReceived(msg))
28 return true;
29
30 // No filter handled the message, so store it.
24 messages_.push_back(Message(msg)); 31 messages_.push_back(Message(msg));
25 return true; 32 return true;
26 } 33 }
27 34
28 void TestSink::ClearMessages() { 35 void TestSink::ClearMessages() {
29 messages_.clear(); 36 messages_.clear();
30 } 37 }
31 38
32 const Message* TestSink::GetMessageAt(size_t index) const { 39 const Message* TestSink::GetMessageAt(size_t index) const {
33 if (index >= messages_.size()) 40 if (index >= messages_.size())
(...skipping 16 matching lines...) Expand all
50 if (messages_[i].type() == id) { 57 if (messages_[i].type() == id) {
51 found_count++; 58 found_count++;
52 found_index = i; 59 found_index = i;
53 } 60 }
54 } 61 }
55 if (found_count != 1) 62 if (found_count != 1)
56 return NULL; // Didn't find a unique one. 63 return NULL; // Didn't find a unique one.
57 return &messages_[found_index]; 64 return &messages_[found_index];
58 } 65 }
59 66
67 void TestSink::AddFilter(Channel::Listener* filter) {
68 filter_list_.AddObserver(filter);
69 }
70
71 void TestSink::RemoveFilter(Channel::Listener* filter) {
72 filter_list_.RemoveObserver(filter);
73 }
74
60 } // namespace IPC 75 } // namespace IPC
OLDNEW
« no previous file with comments | « ipc/ipc_test_sink.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698