Make the sync integration tests self-contained on autotest

Make the sync integration tests self-contained on autotest

In the past, the sync integration tests used to require a password file
stored on every test device in order to do a gaia sign in using
production gaia servers. This caused the tests to be brittle.

As of today, the sync integration tests no longer rely on a password
file, with gaia sign in being stubbed out locally.

This patch reconfigures the tests on autotest, so that it no longer
looks for a local password file.

In addition, the tests run much faster now, and therefore, we reduce the
max timeout to a more reasonable 2 minutes (in the extreme case).

BUG=chromium-os:11294, chromium-os:9262
TEST=sync_integration_tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72561

[Raghu Simha, 2011-01-25 21:50:05]

Dale, please review. Thanks.

[DaleCurtis, 2011-01-25 21:54:41]

Submit a CL for the autotest-private repo to cleanup the password file too
please.

http://codereview.chromium.org/6387004/diff/1/chrome/test/chromeos/autotest/f...
File
chrome/test/chromeos/autotest/files/client/site_tests/desktopui_SyncIntegrationTests/desktopui_SyncIntegrationTests.py
(right):

http://codereview.chromium.org/6387004/diff/1/chrome/test/chromeos/autotest/f...
chrome/test/chromeos/autotest/files/client/site_tests/desktopui_SyncIntegrationTests/desktopui_SyncIntegrationTests.py:10:
binary_to_run='sync_integration_tests'
<space>=<space>

http://codereview.chromium.org/6387004/diff/1/chrome/test/chromeos/autotest/f...
chrome/test/chromeos/autotest/files/client/site_tests/desktopui_SyncIntegrationTests/desktopui_SyncIntegrationTests.py:14:
'--test-terminate-timeout=120000')
If you're going to make the binary a constant, why not the timeout?

[Raghu Simha, 2011-01-25 22:12:01]

I don't have a checkout of the autotest-private repo, and I'm not sure I even
have access. Is this patch something you can easily merge after I commit to
chromium? If not, can you send me instructions on how to merge it to
autotest-private?

http://codereview.chromium.org/6387004/diff/1/chrome/test/chromeos/autotest/f...
File
chrome/test/chromeos/autotest/files/client/site_tests/desktopui_SyncIntegrationTests/desktopui_SyncIntegrationTests.py
(right):

http://codereview.chromium.org/6387004/diff/1/chrome/test/chromeos/autotest/f...
chrome/test/chromeos/autotest/files/client/site_tests/desktopui_SyncIntegrationTests/desktopui_SyncIntegrationTests.py:10:
binary_to_run='sync_integration_tests'
On 2011/01/25 21:54:41, dalec wrote:
> <space>=<space>

Done.

http://codereview.chromium.org/6387004/diff/1/chrome/test/chromeos/autotest/f...
chrome/test/chromeos/autotest/files/client/site_tests/desktopui_SyncIntegrationTests/desktopui_SyncIntegrationTests.py:14:
'--test-terminate-timeout=120000')
On 2011/01/25 21:54:41, dalec wrote:
> If you're going to make the binary a constant, why not the timeout?

Done.

[DaleCurtis, 2011-01-25 22:17:45]

It's easier to remove myself then, CL sent for removal.
LGTM

http://codereview.chromium.org/6387004/diff/5001/chrome/test/chromeos/autotes...
File
chrome/test/chromeos/autotest/files/client/site_tests/desktopui_SyncIntegrationTests/desktopui_SyncIntegrationTests.py
(right):

http://codereview.chromium.org/6387004/diff/5001/chrome/test/chromeos/autotes...
chrome/test/chromeos/autotest/files/client/site_tests/desktopui_SyncIntegrationTests/desktopui_SyncIntegrationTests.py:11:
cmd_line_params = '--test-terminate-timeout=120000'
I was referring only to the 120000 part in my last comment, but this works as
well. Whatever you feel is more readable.