Issue 6386025: Disabling building of CEEE; we will be moving the code to a separate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6386025: Disabling building of CEEE; we will be moving the code to a separate (Closed)

Created:
9 years, 10 months ago by Jói

Modified:
9 years, 7 months ago

Reviewers:
amit

CC:
chromium-reviews, amit, Paweł Hajdan Jr., ceee-reviews_chromium.org, skerner

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Disabling building of CEEE; we will be moving the code to a separate repository. Removing chrome_frame -> ceee dependency. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73195

Patch Set 1 #

Patch Set 2 : Remove presubmit file that depends on ceee. #

Patch Set 3 : merge to head #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -186 lines)			Patch
M	build/all.gyp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/chrome.gyp	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/chrome_installer.gypi	View		1 chunk	+0 lines, -3 lines	0 comments	Download
D	chrome_frame/PRESUBMIT.py	View	1	1 chunk	+0 lines, -30 lines	0 comments	Download
M	chrome_frame/chrome_frame.gyp	View		3 chunks	+0 lines, -41 lines	0 comments	Download
M	chrome_frame/chrome_frame_activex_base.h	View	1 2	2 chunks	+1 line, -7 lines	0 comments	Download
D	chrome_frame/test/chrome_frame_activex_unittest.cc	View		1 chunk	+0 lines, -100 lines	0 comments	Download
M	chrome_frame/test/chrome_frame_test_utils.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jói

Amit, please take a look. I figure chrome_frame may want some of the unit test ...

9 years, 10 months ago (2011-01-31 16:31:44 UTC) #1

amit

lgtm, thanks! I agree, we could get things copied as needed.

9 years, 10 months ago (2011-01-31 21:13:21 UTC) #2

Jói

9 years, 10 months ago (2011-01-31 21:57:47 UTC) #3

This is now committed.

Sam, you asked to be notified.

MAD, you can go ahead and remove the entire ceee/ directory from the
Chromium repository once you've copied it to the new code.google.com
project.  Run a try job of course, but there shouldn't be anything
remaining in the Chromium build that references anything under ceee/.

Cheers,
Jói

On Mon, Jan 31, 2011 at 4:13 PM,  <amit@chromium.org> wrote:
> lgtm, thanks!
>
> I agree, we could get things copied as needed.
>
> http://codereview.chromium.org/6386025/
>

Expand Messages | Collapse Messages