Issue 6386019: Remove obsolete files from 'sources'. This causes needless work on incrementa...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6386019: Remove obsolete files from 'sources'. This causes needless work on incrementa... (Closed)

Created:
9 years, 10 months ago by jeanluc1

Modified:
9 years, 6 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews, cbentzel+watch_chromium.org, Alpha Left Google, Sergey Ulanov, apatrick_chromium, dmac, darin-cc_chromium.org, awong, garykac, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Remove obsolete files from 'sources'. This causes needless work on incremental builds in VS2010. BUG=71130 TEST=Check that Chrome builds. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73190

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -26 lines)			Patch
M	app/app_base.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	base/base.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/chrome_renderer.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/gpu.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/net.gyp	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	remoting/remoting.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	skia/skia.gyp	View	6 chunks	+4 lines, -5 lines	0 comments	Download
M	third_party/cacheinvalidation/cacheinvalidation.gyp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	third_party/libjingle/libjingle.gyp	View	5 chunks	+0 lines, -5 lines	0 comments	Download
M	third_party/libxml/libxml.gyp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	third_party/protobuf/protobuf.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	views/views.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jeanluc1

Same as http://codereview.chromium.org/6307018/ but without the changes to chrome_frame (which created a build break). chrome_frame ...

9 years, 10 months ago (2011-01-31 06:55:44 UTC) #1

LGTM

Expand Messages | Collapse Messages