Remove app/win/win_util.h,cc etc.

Cross-platform CL to remove app/win/win_util.h&cc and related work. 
See Issue 70141 for the full move details; see my inline review comments. 

Changes significantly different from or beyond those prescribed by the bug:
*Consolidated a lot of GrabWindowSnapshot code.
*Moved EnsureRectIsVisibleInRect to views::internal namespace for test access.
*Moved app/win/win_util_unittest.cc to views/window/window_win_unittest.h
*Named ui/base/message_box_win.h instead of ui/base/message_box.h
*Made WindowWin::GetWindowTitleFont static; needed in static contexts.
*Denoted WindowWin::FrameTypeChanged as a Window override, moved code.
*Moved TestGrabWindowSnapshot into new file: chrome/browser/ui/window_snapshot/window_snapshot_mac_unittest.mm

BUG=70141
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73589

[msw, 2011-01-27 17:34:43]

Ready for review!
I'm going to preemptively tackle this nits:
*Update copyright in base/mac/mac_util.mm
*Reorder #include "ui/base/message_box_win.h" in
chrome/browser/ui/views/frame/browser_view.cc
*Revert views/window/window.h (only (c) change)

[msw, 2011-01-27 17:35:19]

On 2011/01/27 17:34:43, msw wrote:
> Ready for review!
> I'm going to preemptively tackle this nits:
> *Update copyright in base/mac/mac_util.mm
> *Reorder #include "ui/base/message_box_win.h" in
> chrome/browser/ui/views/frame/browser_view.cc
> *Revert views/window/window.h (only (c) change)

brettw: please review the naming of src/chrome/common/section_util_win.h/cc

[Ben Goodger (Google), 2011-01-27 18:44:21]

http://codereview.chromium.org/6386009/diff/10001/chrome/browser/ui/views/fra...
File chrome/browser/ui/views/frame/browser_view.cc (right):

http://codereview.chromium.org/6386009/diff/10001/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/browser_view.cc:1147: MB_OK | MB_ICONWARNING |
MB_TOPMOST);
Can this whole function be rewritten to use platform_util?

http://codereview.chromium.org/6386009/diff/10001/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/browser_view.cc:1404: gfx::NativeWindow
native_window= window->GetNativeWindow();
space before =

http://codereview.chromium.org/6386009/diff/10001/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/browser_view.cc:1405:
browser::GrabWindowSnapshot(native_window, png_representation);
Does anyone actually call this method? I don't think they need to anymore... it
could be removed from BrowserWindow and all the platform impls.

[Ben Goodger (Google), 2011-01-27 18:51:00]

Question...

Do people call platform_util::MessageBox or whatever it's called a lot? Do
people in code below chrome in the abstraction onion call MessageBox/NSAlert/etc
a lot? Would it be worth migrating the code from platform_util into
message_box_* impls here in ui/base? Let me know if there are a lot of
messagebox calls for various platforms outside of chrome.

[msw, 2011-02-01 23:12:56]

I finally solved the Mac test initialization problems! Please review.

Regarding your MessageBox questions:
There are ~3 calls to each of platform_util::SimpleErrorBox and SimpleYesNoBox.
There are hundreds of calls to MessageBox; and dozens to each of ShowDialog and
NSAlert.
The majority of calls are within Chrome, but MessageBox does have dozens outside
chrome.
I propose that I log another Issue to investigate consolidating/cleaning up that
code.

I also have a list of other tiny cleanup ideas; I'll try to run them by you or
someone else.

Mike

http://codereview.chromium.org/6386009/diff/10001/chrome/browser/ui/views/fra...
File chrome/browser/ui/views/frame/browser_view.cc (right):

http://codereview.chromium.org/6386009/diff/10001/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/browser_view.cc:1147: MB_OK | MB_ICONWARNING |
MB_TOPMOST);
On 2011/01/27 18:44:22, Ben Goodger wrote:
> Can this whole function be rewritten to use platform_util?

It's not a perfect match. I'll tweak this & other MessageBox code in a
subsequent change (maybe in a new issue...)

http://codereview.chromium.org/6386009/diff/10001/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/browser_view.cc:1404: gfx::NativeWindow
native_window= window->GetNativeWindow();
On 2011/01/27 18:44:22, Ben Goodger wrote:
> space before =

Not applicable in updated CL.
How did static analysis and I miss this? Good catch.

http://codereview.chromium.org/6386009/diff/10001/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/browser_view.cc:1405:
browser::GrabWindowSnapshot(native_window, png_representation);
On 2011/01/27 18:44:22, Ben Goodger wrote:
> Does anyone actually call this method? I don't think they need to anymore...
it
> could be removed from BrowserWindow and all the platform impls.

Good point; the updated CL consolidates a lot of GrabWindowSnapshot code.

[msw, 2011-02-03 05:21:48]

Ben gave this change a verbal LGTM this afternoon.
I'm going to land this imminently, please alert me of any outstanding concerns.
I removed the NSApp changes, as those were addressed by r73581.
Thanks,
Mike