Issue 6386001: dom-ui settings: Tweak 'text-button' css to not conflict with 'button' custom...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6386001: dom-ui settings: Tweak 'text-button' css to not conflict with 'button' custom... (Closed)

Created:
9 years, 11 months ago by csilv

Modified:
9 years, 7 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

dom-ui settings: Tweak 'text-button' css to not conflict with 'button' customizations. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72213

Patch Set 1 #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	chrome/browser/resources/options/options_page.css	View		1 chunk	+7 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

http://codereview.chromium.org/6386001/diff/1/chrome/browser/resources/options/options_page.css File chrome/browser/resources/options/options_page.css (right): http://codereview.chromium.org/6386001/diff/1/chrome/browser/resources/options/options_page.css#newcode349 chrome/browser/resources/options/options_page.css:349: .text-button, Hmm, need to check out .raw-button and refactor ...

9 years, 11 months ago (2011-01-21 21:08:50 UTC) #2

csilv

text-button is used in the languages panel to make a button look like a text ...

9 years, 11 months ago (2011-01-21 21:14:17 UTC) #3

James Hawkins

9 years, 11 months ago (2011-01-21 21:16:50 UTC) #4

On 2011/01/21 21:14:17, csilv wrote:
> text-button is used in the languages panel to make a button look like a text
> field... so it's different than raw-button and not really applicable to
> refactoring.
> 
> In retrospect, it'd probably be better to get rid of text-button entirely and
> just insert text fields instead, but I think that's a project for another day,
> maybe along with a UI refresh for this panel.

Okie. LGTM

Expand Messages | Collapse Messages