Issue 6385004: Fix uninitialized variables introduced in CL 72374. time_slice_hrs was causin...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6385004: Fix uninitialized variables introduced in CL 72374. time_slice_hrs was causin... (Closed)

Created:
9 years, 11 months ago by ddorwin

Modified:
9 years, 7 months ago

Reviewers:
Miranda Callahan, scherkus (not reviewing)

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix uninitialized variables introduced in CL 72374. time_slice_hrs is being used uninitialized at line 459, and this was causing a Run-Time Check failure and crash in Debug versions on Windows. I don't know whether 0 is the the correct value in this case, but this fixes the crash. mirandac@ will need to review the behavior. BUG=None TEST=Run debug version of Chrome on Windows and wait a few seconds. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72444

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/web_resource/web_resource_service.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

don't forget to use "None" for empty BUG= / TEST= fields! other than that LGTM

9 years, 11 months ago (2011-01-25 01:24:32 UTC) #3

Miranda Callahan

9 years, 11 months ago (2011-01-25 01:58:05 UTC) #5

On 2011/01/25 01:27:44, ddorwin wrote:

Yes, 0 is the correct initialization value -- thanks for catching this.

Expand Messages | Collapse Messages