Issue 6385002: Add expectation for NetworkLibrary.IsLocked (fix for 6292008)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6385002: Add expectation for NetworkLibrary.IsLocked (fix for 6292008) (Closed)

Created:
9 years, 11 months ago by stevenjb

Modified:
9 years, 7 months ago

Reviewers:
stevenjb (google-dont-use), oshima

CC:
chromium-reviews, davemoore+watch_chromium.org, zel, Charlie Lee

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add expectation for NetworkLibrary.IsLocked (fix for 6292008) BUG=chromium-os:9870 TEST=Run browser_tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72267

Patch Set 1 #

Patch Set 2 : Change expectation to AnyNumber() #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/browser/chromeos/cros/cros_mock.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

zel

I've fixed and checked in this earlier today. Please sync your sources. On Fri, Jan ...

9 years, 11 months ago (2011-01-22 06:02:59 UTC) #4

stevenjb (google-dont-use)

9 years, 11 months ago (2011-01-22 06:07:34 UTC) #5

Yeah, I saw your fix while we were troubleshooting a different problem with
the tests. Sorry I didn't notice it when I applied my patch. (My tree was up
to date, but it didn't occur to me that the bot was that far behind).
Fortunately my addition didn't really have any effect; we can revert it on
Monday once the tree is (hopefully) more green.

On Fri, Jan 21, 2011 at 10:02 PM, Zelidrag Hornung <zelidrag@chromium.org>wrote:

> I've fixed and checked in this earlier today. Please sync your sources.
>
>
>
> On Fri, Jan 21, 2011 at 7:38 PM, <oshima@chromium.org> wrote:
>
>> LGTM
>>
>> thanks!
>>
>>
>> http://codereview.chromium.org/6385002/
>>
>
>

Expand Messages | Collapse Messages