Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: src/ia32/lithium-ia32.cc

Issue 6384020: Remove the redundant load on every context lookup. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge/build/ia32
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ia32/lithium-ia32.cc
diff --git a/src/ia32/lithium-ia32.cc b/src/ia32/lithium-ia32.cc
index 1d5cefcb4996e7e0fa1f5a0e2263854a555937b3..21cfcc6b9a0df3601b9737a0ab6767f09e191713 100644
--- a/src/ia32/lithium-ia32.cc
+++ b/src/ia32/lithium-ia32.cc
@@ -1685,14 +1685,16 @@ LInstruction* LChunkBuilder::DoLoadContextSlot(HLoadContextSlot* instr) {
LInstruction* LChunkBuilder::DoStoreContextSlot(HStoreContextSlot* instr) {
- LOperand* context = UseTempRegister(instr->context());
+ LOperand* context;
LOperand* value;
LOperand* temp;
if (instr->NeedsWriteBarrier()) {
+ context = UseTempRegister(instr->context());
value = UseTempRegister(instr->value());
temp = TempRegister();
} else {
- value = UseRegister(instr->value());
+ context = UseRegisterAtStart(instr->context());
+ value = UseRegisterAtStart(instr->value());
fschneider 2011/02/04 11:29:58 This is perfectly valid, but i think the AtStart w
Kevin Millikin (Chromium) 2011/02/04 11:51:48 I was trying to be consistent, but I guess UseRegi
temp = NULL;
}
return new LStoreContextSlot(context, value, temp);

Powered by Google App Engine
This is Rietveld 408576698