Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6384002: views: Make CreatePanelGridLayout a static method of GridLayout class. (Closed)

Created:
9 years, 11 months ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

views: Make CreatePanelGridLayout a static method of GridLayout class. Move it from standard_layout.h and rename to just CreatePanel. BUG=None TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72128

Patch Set 1 : #

Patch Set 2 : fix trybots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -54 lines) Patch
M chrome/browser/chromeos/login/captcha_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/eula_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/password_changed_view.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/options/internet_page_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/system_page_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/first_run/first_run_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/input_window_dialog_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/about_ipc_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/autofill_profiles_view_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmark_editor_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/clear_browsing_data_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/clear_server_data.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/collected_cookies_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/edit_search_engine_dialog.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/hung_renderer_view.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/importer_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/importing_progress_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/instant_confirm_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/keyword_editor_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/login_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/advanced_contents_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/advanced_page_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/cookies_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/exception_editor_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/exceptions_page_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/fonts_page_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/languages_page_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/passwords_page_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/uninstall_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/url_picker.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M views/controls/message_box_view.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M views/grid_layout.h View 2 chunks +4 lines, -1 line 0 comments Download
M views/grid_layout.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M views/standard_layout.h View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
This is ready for review. Please, take a look.
9 years, 11 months ago (2011-01-20 17:25:29 UTC) #1
sky
9 years, 11 months ago (2011-01-20 17:49:58 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698