Issue 6382005: Unpatch the ChromeFrame IHttpNegotiate patch for all browsers....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6382005: Unpatch the ChromeFrame IHttpNegotiate patch for all browsers.... (Closed)

Created:
9 years, 11 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
amit

CC:
chromium-reviews, amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Unpatch the ChromeFrame IHttpNegotiate patch for all browsers. BUG=70138 TEST=none TBR=amit Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72043

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	chrome_frame/bho.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

amit

9 years, 11 months ago (2011-01-20 23:48:38 UTC) #2

Good catch. lg

On Thu, Jan 20, 2011 at 3:39 PM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Unpatch the ChromeFrame IHttpNegotiate patch for all browsers.
>
> BUG=70138
> TEST=none
> TBR=amit
>
>
> Please review this at http://codereview.chromium.org/6382005/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/bho.cc
>
>
> Index: chrome_frame/bho.cc
> ===================================================================
> --- chrome_frame/bho.cc (revision 71887)
> +++ chrome_frame/bho.cc (working copy)
> @@ -383,9 +383,7 @@
>  void PatchHelper::UnpatchIfNeeded() {
>   if (state_ == PATCH_PROTOCOL) {
>     g_trans_hooks.RevertHooks();
> -    if (GetIEVersion() == IE_9) {
> -      HttpNegotiatePatch::Uninitialize();
> -    }
> +    HttpNegotiatePatch::Uninitialize();
>   }
>   state_ = UNKNOWN;
>  }
>
>
>

Expand Messages | Collapse Messages