Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: net/url_request/url_request_http_job.h

Issue 6382003: Reorder the methods in net/url_request/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compiling net_unittests != compiling the rest of chrome Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request_ftp_job.cc ('k') | net/url_request/url_request_http_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_http_job.h
diff --git a/net/url_request/url_request_http_job.h b/net/url_request/url_request_http_job.h
index fbd8baff69ae9f2e637718738a4de159b4cad155..3f9356e62155e9e5c6550a63f2a7aa449b5d9a11 100644
--- a/net/url_request/url_request_http_job.h
+++ b/net/url_request/url_request_http_job.h
@@ -34,6 +34,31 @@ class URLRequestHttpJob : public URLRequestJob {
protected:
explicit URLRequestHttpJob(URLRequest* request);
+ // Shadows URLRequestJob's version of this method so we can grab cookies.
+ void NotifyHeadersComplete();
+
+ void DestroyTransaction();
+ void StartTransaction();
+ void AddExtraHeaders();
+ void AddCookieHeaderAndStart();
+ void SaveCookiesAndNotifyHeadersComplete();
+ void SaveNextCookie();
+ void FetchResponseCookies(const HttpResponseInfo* response_info,
+ std::vector<std::string>* cookies);
+
+ // Process the Strict-Transport-Security header, if one exists.
+ void ProcessStrictTransportSecurityHeader();
+
+ void OnCanGetCookiesCompleted(int result);
+ void OnCanSetCookieCompleted(int result);
+ void OnStartCompleted(int result);
+ void OnReadCompleted(int result);
+
+ bool ShouldTreatAsCertificateError(int result);
+
+ void RestartTransactionWithAuth(const string16& username,
+ const string16& password);
+
// Overridden from URLRequestJob:
virtual void SetUpload(UploadData* upload);
virtual void SetExtraRequestHeaders(const HttpRequestHeaders& headers);
@@ -61,31 +86,6 @@ class URLRequestHttpJob : public URLRequestJob {
virtual bool ReadRawData(IOBuffer* buf, int buf_size, int *bytes_read);
virtual void StopCaching();
- // Shadows URLRequestJob's version of this method so we can grab cookies.
- void NotifyHeadersComplete();
-
- void DestroyTransaction();
- void StartTransaction();
- void AddExtraHeaders();
- void AddCookieHeaderAndStart();
- void SaveCookiesAndNotifyHeadersComplete();
- void SaveNextCookie();
- void FetchResponseCookies(const HttpResponseInfo* response_info,
- std::vector<std::string>* cookies);
-
- // Process the Strict-Transport-Security header, if one exists.
- void ProcessStrictTransportSecurityHeader();
-
- void OnCanGetCookiesCompleted(int result);
- void OnCanSetCookieCompleted(int result);
- void OnStartCompleted(int result);
- void OnReadCompleted(int result);
-
- bool ShouldTreatAsCertificateError(int result);
-
- void RestartTransactionWithAuth(const string16& username,
- const string16& password);
-
// Keep a reference to the url request context to be sure it's not deleted
// before us.
scoped_refptr<URLRequestContext> context_;
« no previous file with comments | « net/url_request/url_request_ftp_job.cc ('k') | net/url_request/url_request_http_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698