Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: chrome/browser/resources/options/chromeos_accounts_user_list.js

Issue 6380015: Fix ChromeOS users list multiple X problem. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: apply kochi's fix and for his comments #1 Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/options/chromeos_accounts_options_page.css ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/chromeos_accounts_user_list.js
diff --git a/chrome/browser/resources/options/chromeos_accounts_user_list.js b/chrome/browser/resources/options/chromeos_accounts_user_list.js
index 36f565fa12ee23af0e257cfcd09454af4dae795b..591dc953170506b6c66c9bcb313688357be3060d 100644
--- a/chrome/browser/resources/options/chromeos_accounts_user_list.js
+++ b/chrome/browser/resources/options/chromeos_accounts_user_list.js
@@ -103,7 +103,7 @@ cr.define('options.accounts', function() {
// Handle left button click
if (e.button == 0) {
var el = e.target;
- if (el.className == 'remove-user-button') {
+ if (el.classList.contains('remove-user-button')) {
this.removeUser(el.parentNode.user);
}
}
@@ -173,13 +173,21 @@ cr.define('options.accounts', function() {
localStrings.getStringF('username_format', this.user.name) :
this.user.name;
+ var emailNameBlock = this.ownerDocument.createElement('div');
+ emailNameBlock.className = 'user-email-name-block';
+ emailNameBlock.appendChild(labelEmail);
+ emailNameBlock.appendChild(labelName);
+ emailNameBlock.title = this.user.owner ?
+ localStrings.getStringF('username_format', this.user.email) :
+ this.user.email;
+
this.appendChild(icon);
- this.appendChild(labelEmail);
- this.appendChild(labelName);
+ this.appendChild(emailNameBlock);
if (!this.user.owner) {
var removeButton = this.ownerDocument.createElement('button');
- removeButton.className = 'remove-user-button';
+ removeButton.classList.add('raw-button');
+ removeButton.classList.add('remove-user-button');
this.appendChild(removeButton);
}
}
« no previous file with comments | « chrome/browser/resources/options/chromeos_accounts_options_page.css ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698