Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: chrome/browser/autocomplete/autocomplete_popup_model.cc

Issue 6380012: Fix a CHECK failure in AutocompletePopupModel::InfoForCurrentSelection(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Correct solution. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autocomplete/autocomplete_edit.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/autocomplete_popup_model.cc
diff --git a/chrome/browser/autocomplete/autocomplete_popup_model.cc b/chrome/browser/autocomplete/autocomplete_popup_model.cc
index 588683dc4b96148ec578265f0f47516c8cd3aae8..d62272bd3c524dc123845c5798f09d8b6ced40e9 100644
--- a/chrome/browser/autocomplete/autocomplete_popup_model.cc
+++ b/chrome/browser/autocomplete/autocomplete_popup_model.cc
@@ -317,8 +317,15 @@ void AutocompletePopupModel::Observe(NotificationType type,
if ((hovered_line_ != kNoMatch) && (result->size() <= hovered_line_))
SetHoveredLine(kNoMatch);
+ const bool was_open = view_->IsOpen();
view_->UpdatePopupAppearance();
- edit_model_->PopupBoundsChangedTo(view_->GetTargetBounds());
+
Peter Kasting 2011/01/24 22:10:19 Nit: Unnecessary blank line
+ if (view_->IsOpen()) {
+ edit_model_->PopupBoundsChangedTo(view_->GetTargetBounds());
+ } else if (was_open) {
+ edit_model_->PopupBoundsChangedTo(gfx::Rect());
Peter Kasting 2011/01/24 22:10:19 Nit: Let's roll this call into the body of OnPopup
+ edit_model_->OnPopupClosed();
+ }
}
const SkBitmap* AutocompletePopupModel::GetSpecialIconForMatch(
« no previous file with comments | « chrome/browser/autocomplete/autocomplete_edit.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698